Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test workflow #2718

Merged
merged 10 commits into from
Dec 12, 2023

Conversation

vinnamkim
Copy link
Contributor

Summary

  • Add a regression test workflow which is based on MLFlow Tracking server for better maintenance and automated test workflow.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM TEST Any changes in tests BUILD DOC Improvements or additions to documentation OTX 2.0 labels Dec 12, 2023
@vinnamkim vinnamkim marked this pull request as ready for review December 12, 2023 03:21
@vinnamkim vinnamkim force-pushed the impl-regression-test branch 2 times, most recently from 7cb9a1f to c4dc9f8 Compare December 12, 2023 03:46
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim force-pushed the impl-regression-test branch 2 times, most recently from 764942c to 1502cf4 Compare December 12, 2023 04:07
@github-actions github-actions bot removed the TEST Any changes in tests label Dec 12, 2023
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@github-actions github-actions bot added the TEST Any changes in tests label Dec 12, 2023
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
sungmanc
sungmanc previously approved these changes Dec 12, 2023
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice introduction. BTW, is there no SDL issue to use the postgress DB? maybe we need confirm from Yunchu?

@vinnamkim
Copy link
Contributor Author

Thanks for the nice introduction. BTW, is there no SDL issue to use the postgress DB? maybe we need confirm from Yunchu?

Thanks, I'll contact him.

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
This reverts commit 676bdbd.
@vinnamkim vinnamkim requested a review from sungmanc December 12, 2023 05:49
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinnamkim vinnamkim merged commit 539cbe7 into openvinotoolkit:v2 Dec 12, 2023
6 checks passed
@vinnamkim vinnamkim deleted the impl-regression-test branch December 12, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUILD DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants