Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the cls head to make them same with the otx1.5 #2716

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

sungmanc
Copy link
Contributor

Summary

To ensure backward compatibility, we need to use the same head architecture.
So, I changed the head architecture to make the same head with OTX 1.5.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where were the previous configs coming from?

jaegukhyun
jaegukhyun previously approved these changes Dec 11, 2023
@sungmanc
Copy link
Contributor Author

Where were the previous configs coming from?

It comes from the default ImageClassifier of MobileNet-v3 from MMPretrain

@vinnamkim
Copy link
Contributor

Where were the previous configs coming from?

It comes from the default ImageClassifier of MobileNet-v3 from MMPretrain

Did you compare the model accuracy results between the previous configs and this PRs? It is important to keep in mind that if some of legacy are found to be not good, we should throw it away rather than maintaining it blindly.

@sungmanc
Copy link
Contributor Author

Did you compare the model accuracy results between the previous configs and this PRs? It is important to keep in mind that if some of legacy are found to be not good, we should throw it away rather than maintaining it blindly.

Now I'm checking the results. In my opinion, we should keep the head architecture with OTX 1.5.
If there was a user who used the Geti classification with OTX1.5, we should keep the accuracy if the user used the same dataset.
However, if the head architecture is different, we can't guarantee the previous model's accuracy due to the difference in the head.

That's the reason why I reverted the head architecture to the OTX1.5.

I'm not sure we should change the head architecture although some backward compatibilities could be broken.

@sungmanc
Copy link
Contributor Author

I discussed with the Mark, and we're going to support the backward compatible model (light.yaml) and otx model (otx*).
Since I don't want to use the Geti word into the recipe, I used the light word. cc. @vinnamkim

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sungmanc sungmanc merged commit 13d6bf3 into openvinotoolkit:v2 Dec 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants