-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the cls head to make them same with the otx1.5 #2716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where were the previous configs coming from?
It comes from the default ImageClassifier of MobileNet-v3 from MMPretrain |
Did you compare the model accuracy results between the previous configs and this PRs? It is important to keep in mind that if some of legacy are found to be not good, we should throw it away rather than maintaining it blindly. |
Now I'm checking the results. In my opinion, we should keep the head architecture with OTX 1.5. That's the reason why I reverted the head architecture to the OTX1.5. I'm not sure we should change the head architecture although some backward compatibilities could be broken. |
I discussed with the Mark, and we're going to support the backward compatible model (light.yaml) and otx model (otx*). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Summary
To ensure backward compatibility, we need to use the same head architecture.
So, I changed the head architecture to make the same head with OTX 1.5.
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.