Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring the SOTA(DINOv2) model to the classification task #2708

Merged
merged 20 commits into from
Dec 11, 2023

Conversation

sungmanc
Copy link
Contributor

@sungmanc sungmanc commented Dec 7, 2023

Summary

This PR includes:

  • DINO-v2-register-small model implementation and experimental results.
  • Wrap the common thing of configs/models/*.yaml
  • Used the MMpretrain's data pipeline, Torchvision transforms will be introduced at the further PR.
  • Add tests for the DINO-v2 model

Experimental results: (iter_time_epoch) will be noted at OneNote.

  • To experiment with the DINO-v2-register-small model, I freeze the backbone. If not, the model couldn't training well.
    image

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM TEST Any changes in tests BUILD OTX 2.0 labels Dec 7, 2023
vinnamkim
vinnamkim previously approved these changes Dec 8, 2023
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

harimkang
harimkang previously approved these changes Dec 8, 2023
Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/otx/config/model/default.yaml Show resolved Hide resolved
@sungmanc sungmanc dismissed stale reviews from harimkang and vinnamkim via 4f1f551 December 8, 2023 04:52
jaegukhyun
jaegukhyun previously approved these changes Dec 8, 2023
@sungmanc sungmanc requested a review from harimkang December 8, 2023 08:45
@sungmanc sungmanc merged commit 9a1dc19 into openvinotoolkit:v2 Dec 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUILD DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants