Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mergeback from 1.4.0 to 1.5.0 #2659

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Mergeback from 1.4.0 to 1.5.0 #2659

merged 3 commits into from
Nov 21, 2023

Conversation

yunchu
Copy link
Contributor

@yunchu yunchu commented Nov 21, 2023

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

* Make max_num_detections configurable

* Fix RCNN case with integration test

* Apply max_num_detections to train_cfg, too

---------
Signed-off-by: Songki Choi <songki.choi@intel.com>
Fix bug that auto adaptive batch size raises an error if CUDA isn't available (#2410)

---------
Co-authored-by: Sungman Cho <sungman.cho@intel.com>
Co-authored-by: Eunwoo Shin <eunwoo.shin@intel.com>
@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests DOC Improvements or additions to documentation labels Nov 21, 2023
@yunchu yunchu changed the base branch from develop to releases/1.5.0 November 21, 2023 02:05
@yunchu yunchu force-pushed the mergeback/140to150 branch 2 times, most recently from 9f1f231 to fe12f18 Compare November 21, 2023 04:24
goodsong81
goodsong81 previously approved these changes Nov 21, 2023
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (9909d17) 80.90% compared to head (2a936f0) 80.87%.

Files Patch % Lines
.../algorithms/detection/adapters/mmdet/configurer.py 18.75% 13 Missing ⚠️
...rc/otx/algorithms/detection/adapters/mmdet/task.py 16.66% 5 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.5.0    #2659      +/-   ##
==================================================
- Coverage           80.90%   80.87%   -0.03%     
==================================================
  Files                 515      515              
  Lines               38247    38278      +31     
==================================================
+ Hits                30945    30959      +14     
- Misses               7302     7319      +17     
Flag Coverage Δ
py310 80.87% <47.05%> (-0.03%) ⬇️
py38 80.85% <47.05%> (-0.04%) ⬇️
py39 80.85% <47.05%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yunchu yunchu marked this pull request as ready for review November 21, 2023 07:53
@yunchu yunchu requested a review from a team as a code owner November 21, 2023 07:53
@yunchu yunchu merged commit a49d58f into releases/1.5.0 Nov 21, 2023
13 of 15 checks passed
@yunchu yunchu deleted the mergeback/140to150 branch November 21, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants