Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary log while building a model #2658

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Remove unnecessary log while building a model #2658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f03ccb
revert logger in otx/algorithms/detection/adapters/mmdet/utils/builde…
eunwoosh Nov 21, 2023
0769c18
revert logger in otx/algorithms/classification/adapters/mmcls/utils/b…
eunwoosh Nov 21, 2023
63d1c55
make change more readable
eunwoosh Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/otx/algorithms/classification/adapters/mmcls/utils/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@

import torch
from mmcv.runner import load_checkpoint
from mmcv.utils import Config, ConfigDict
from mmcv.utils import Config, ConfigDict, get_logger

from otx.utils.logger import LEVEL, get_logger
from otx.utils.logger import LEVEL

logger = get_logger()
mmcls_logger = get_logger("mmcls")


def build_classifier(
Expand All @@ -35,9 +35,9 @@ def build_classifier(

model_cfg = deepcopy(config.model)
model = origin_build_classifier(model_cfg)
logger.setLevel("WARNING")
mmcls_logger.setLevel("WARNING") # make logger less verbose temporally
model.init_weights()
logger.setLevel(LEVEL)
mmcls_logger.setLevel(LEVEL)
model = model.to(device)

checkpoint = checkpoint if checkpoint else config.pop("load_from", None)
Expand Down
10 changes: 5 additions & 5 deletions src/otx/algorithms/detection/adapters/mmdet/utils/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@

import torch
from mmcv.runner import load_checkpoint
from mmcv.utils import Config, ConfigDict
from mmcv.utils import Config, ConfigDict, get_logger

from otx.utils.logger import LEVEL, get_logger
from otx.utils.logger import LEVEL

logger = get_logger()
mmdet_logger = get_logger("mmdet")


def build_detector(
Expand All @@ -37,9 +37,9 @@ def build_detector(

model_cfg = deepcopy(config.model)
model = origin_build_detector(model_cfg, train_cfg=train_cfg, test_cfg=test_cfg)
logger.setLevel("WARNING")
mmdet_logger.setLevel("WARNING") # make logger less verbose temporally
model.init_weights()
logger.setLevel(LEVEL)
mmdet_logger.setLevel(LEVEL)
model = model.to(device)

checkpoint = checkpoint if checkpoint else config.pop("load_from", None)
Expand Down