Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix DatasetEntity.get_combined_subset function loop #2577

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Hotfix DatasetEntity.get_combined_subset function loop #2577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/otx/api/entities/datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,8 +349,9 @@ def get_combined_subset(self, subsets: List[Subset]) -> "DatasetEntity":
Returns:
DatasetEntity: DatasetEntity with items matching subsets
"""
to_keep = set(subsets)
dataset = DatasetEntity(
items=[item for item in self._items if item.subset in set(subsets)],
items=[item for item in self if item.subset in to_keep],
purpose=self.purpose,
)
return dataset
Expand Down