-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable resuming with weights.pth
saved by visual prompting
#2538
Merged
sungchul2
merged 9 commits into
openvinotoolkit:develop
from
sungchul2:vpm-enable-resume
Oct 12, 2023
Merged
Enable resuming with weights.pth
saved by visual prompting
#2538
sungchul2
merged 9 commits into
openvinotoolkit:develop
from
sungchul2:vpm-enable-resume
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ALGO
Any changes in OTX Algo Tasks implementation
TEST
Any changes in tests
labels
Oct 10, 2023
sungchul2
force-pushed
the
vpm-enable-resume
branch
from
October 11, 2023 02:19
564b59b
to
ff0237e
Compare
sungchul2
changed the title
Enable resuming with weights.pth saved by vpm
Enable resuming with Oct 11, 2023
weights.pth
saved by vpm
sungchul2
changed the title
Enable resuming with
Enable resuming with Oct 11, 2023
weights.pth
saved by vpmweights.pth
saved by visual prompting
eunwoosh
reviewed
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work! I left some questions. Please take a look.
jaegukhyun
previously approved these changes
Oct 12, 2023
eunwoosh
approved these changes
Oct 12, 2023
jaegukhyun
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#2274 (comment)
For this, it was needed to save metas for pytorch lightning in
weights.pth
.It was implemented by loading best checkpoint saved in
Trainer.checkpoint_callback
and saving metas inweights.pth
.How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.