Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTX] remove dead code #2528

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

Harmjandevries
Copy link
Contributor

@Harmjandevries Harmjandevries commented Sep 28, 2023

https://jira.devtools.intel.com/browse/CVS-120764

Summary

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

Sorry, something went wrong.

@Harmjandevries Harmjandevries requested a review from a team as a code owner September 28, 2023 10:19
@Harmjandevries Harmjandevries self-assigned this Sep 28, 2023
@github-actions github-actions bot added API Any changes in OTX API TEST Any changes in tests labels Sep 28, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (790b7cf) 81.39% compared to head (2cfaa70) 81.37%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2528      +/-   ##
===========================================
- Coverage    81.39%   81.37%   -0.03%     
===========================================
  Files          518      517       -1     
  Lines        37933    37856      -77     
===========================================
- Hits         30877    30805      -72     
+ Misses        7056     7051       -5     
Flag Coverage Δ
py310 81.36% <ø> (-0.03%) ⬇️
py38 81.35% <ø> (-0.03%) ⬇️
py39 81.35% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/otx/api/entities/model.py 98.78% <ø> (-0.02%) ⬇️
src/otx/api/usecases/adapters/model_adapter.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sovrasov sovrasov requested a review from kprokofi October 2, 2023 11:36
@sovrasov sovrasov merged commit f5dc66a into develop Oct 2, 2023
@sovrasov sovrasov deleted the harmjan/120764_remove_dead_code_from_otx branch October 2, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Any changes in OTX API TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants