Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E2E tests for detection #2520

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

sungmanc
Copy link
Contributor

@sungmanc sungmanc commented Sep 26, 2023

Summary

This PR resolves SemiSL + YOLO errors. Originally, it comes from the multi-scale data pipeline described at the base_semisl data pipeline. Since YOLO family is quite sensitive to image resolution, I made separated data pipelines for YOLOX + Semi SL.

In my local test, all YOLO + SemiSL errors were resolved.
image

Therefore, now we left 3 FAIL cases. So, I just added skip mark for them
image

How to test

E2E tests

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@sungmanc sungmanc added the FIX defect fix label Sep 26, 2023
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Sep 26, 2023
goodsong81
goodsong81 previously approved these changes Sep 26, 2023
@sungmanc sungmanc marked this pull request as ready for review September 26, 2023 06:20
@sungmanc sungmanc requested a review from a team as a code owner September 26, 2023 06:20
@sungmanc sungmanc changed the title Edit yolo data pipeline for semi-sl Fix E2E tests for detection Sep 26, 2023
@github-actions github-actions bot added the TEST Any changes in tests label Sep 26, 2023
@sungmanc sungmanc enabled auto-merge (squash) September 26, 2023 07:28
@sungmanc sungmanc merged commit 24d061f into openvinotoolkit:develop Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation FIX defect fix TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants