Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the incorrect progress information when AdaptiveRepeatDataHook is enabled #2510

Merged
merged 20 commits into from
Oct 4, 2023

Conversation

sungmanc
Copy link
Contributor

@sungmanc sungmanc commented Sep 19, 2023

Summary

This PR resolves an incorrect logging from the OTXProgressHook. Since OTXSampler + AdaptiveRepeatDataHook enlarges the total iterations, it should be applied before calling the OTXProgressHook.

So, I added get_proper_repeat_times function and used this function before_run to change the runner's max_iter.

This PR tackles the incorrect log for the classification task and enable RepeatData to multi-label and H-label. For the other tasks, I'll make another PR.

Since the LR scheduler was changed, I attached the experimental results. Regression datasets for multi-label, h-label were used.

    EfficientNet-b0 Deit-tiny MobileNet_v3_Large
Multi-label (Before) E2E time 0:00:54 0:00:49 0:00:40
  Score 96.51 95.67 96.70
H-label (Before) E2E time 0:01:04 0:00:40 0:00:39
  Score 72.72 73.62 73.03
Multi-label (After) E2E time 0:01:32 0:00:47 0:00:33
  Score 96.50 95.04 96.17
H-label (After) E2E time 0:01:04 0:00:41 0:00:33
  Score 72.37 73.62 72.64

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@sungmanc sungmanc added the FIX defect fix label Sep 19, 2023
@sungmanc sungmanc added this to the 1.5.0 milestone Sep 19, 2023
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Sep 19, 2023
@github-actions github-actions bot added the TEST Any changes in tests label Sep 20, 2023
@sungmanc sungmanc marked this pull request as ready for review September 21, 2023 06:46
@sungmanc sungmanc requested a review from a team as a code owner September 21, 2023 06:46
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, looks good. Could you check my comments?

Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! I left some comments. Please take a look.

eunwoosh
eunwoosh previously approved these changes Oct 4, 2023
@sungmanc sungmanc merged commit 0e82e1e into openvinotoolkit:develop Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation FIX defect fix TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants