-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the incorrect progress information when AdaptiveRepeatDataHook is enabled #2510
Merged
sungmanc
merged 20 commits into
openvinotoolkit:develop
from
sungmanc:fix-ordering-adaptive-hook
Oct 4, 2023
Merged
Fix the incorrect progress information when AdaptiveRepeatDataHook is enabled #2510
sungmanc
merged 20 commits into
openvinotoolkit:develop
from
sungmanc:fix-ordering-adaptive-hook
Oct 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iters before the ProgressHook
goodsong81
reviewed
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, looks good. Could you check my comments?
src/otx/algorithms/common/adapters/mmcv/hooks/adaptive_repeat_data_hook.py
Outdated
Show resolved
Hide resolved
eunwoosh
reviewed
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work! I left some comments. Please take a look.
src/otx/algorithms/common/adapters/mmcv/hooks/adaptive_repeat_data_hook.py
Show resolved
Hide resolved
src/otx/algorithms/common/adapters/mmcv/hooks/adaptive_repeat_data_hook.py
Show resolved
Hide resolved
…_extensions into fix-ordering-adaptive-hook
Co-authored-by: Eunwoo Shin <eunwoo.shin@intel.com>
…anc/training_extensions into fix-ordering-adaptive-hook
goodsong81
reviewed
Sep 25, 2023
eunwoosh
reviewed
Oct 4, 2023
eunwoosh
previously approved these changes
Oct 4, 2023
eunwoosh
approved these changes
Oct 4, 2023
goodsong81
approved these changes
Oct 4, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves an incorrect logging from the
OTXProgressHook
. SinceOTXSampler
+AdaptiveRepeatDataHook
enlarges the total iterations, it should be applied before calling theOTXProgressHook
.So, I added
get_proper_repeat_times
function and used this functionbefore_run
to change the runner's max_iter.This PR tackles the incorrect log for the classification task and enable RepeatData to multi-label and H-label. For the other tasks, I'll make another PR.
Since the LR scheduler was changed, I attached the experimental results. Regression datasets for multi-label, h-label were used.
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.