Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e failed case of visual prompting task #2509

Merged

Conversation

sungchul2
Copy link
Contributor

@sungchul2 sungchul2 commented Sep 19, 2023

Summary

Related ticket: CVS-118394
Fix that e2e test for visual prompting task has sometimes failed as moving load_model after set_seed.

How to test

Tried e2e 20 times to check if there is any failed case.

import subprocess
for _ in range(20):
    subprocess.run("tox -vv -e tests-visprompt-py310 -- tests/e2e/cli/visual_prompting", shell=True)

=================== 7 passed, 1 warning in 104.51s (0:01:44) ===================

Any failed case is not detected on 20 trials.

$ tox -vv -e unittest-all-py310 -- tests/unit/algorithms/visual_prompting

====================== 177 passed, 106 warnings in 29.37s ======================

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@sungchul2 sungchul2 requested a review from a team as a code owner September 19, 2023 05:48
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Sep 19, 2023
@github-actions github-actions bot added the TEST Any changes in tests label Sep 19, 2023
@sungchul2 sungchul2 merged commit d84d925 into openvinotoolkit:develop Sep 19, 2023
@sungchul2 sungchul2 deleted the visual-prompting-e2e-fail branch September 19, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants