Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support torch==2.0.1 #2465

Merged
merged 10 commits into from
Sep 20, 2023
Merged

Support torch==2.0.1 #2465

merged 10 commits into from
Sep 20, 2023

Conversation

goodsong81
Copy link
Contributor

@goodsong81 goodsong81 commented Aug 31, 2023

Summary

How to test

  • Torch1.13.1
tox -e tests-all-py310-pt1
  • Torch2.0.1
tox -e tests-all-py310-pt2
  • Trouble shooting for MMCV _ext.so problem
find ~/.cache/pip -name mmcv* -delete
tox -re tests-all-py310-pt2

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

Signed-off-by: Songki Choi <songki.choi@intel.com>
Signed-off-by: Songki Choi <songki.choi@intel.com>
Signed-off-by: Songki Choi <songki.choi@intel.com>
Signed-off-by: Songki Choi <songki.choi@intel.com>
@github-actions github-actions bot added DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests BUILD labels Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (7eec927) 81.35% compared to head (a131033) 81.35%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2465      +/-   ##
===========================================
- Coverage    81.35%   81.35%   -0.01%     
===========================================
  Files          517      517              
  Lines        37777    37777              
===========================================
- Hits         30735    30734       -1     
- Misses        7042     7043       +1     
Flag Coverage Δ
py310 81.35% <ø> (ø)
py38 81.33% <ø> (ø)
py39 81.33% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Songki Choi <songki.choi@intel.com>
@goodsong81 goodsong81 added this to the 1.5.0 milestone Aug 31, 2023
@goodsong81 goodsong81 changed the title Upgrade torch==2.0.1 Support torch==2.0.1 Sep 19, 2023
@github-actions github-actions bot added DOC Improvements or additions to documentation and removed ALGO Any changes in OTX Algo Tasks implementation labels Sep 19, 2023
@goodsong81 goodsong81 added the FEATURE New feature & functionality label Sep 19, 2023
@goodsong81 goodsong81 requested a review from yunchu September 19, 2023 05:39
Signed-off-by: Songki Choi <songki.choi@intel.com>
@goodsong81 goodsong81 marked this pull request as ready for review September 19, 2023 08:52
@goodsong81 goodsong81 requested a review from a team as a code owner September 19, 2023 08:52
Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have a minor question. Please take a look.

tox.ini Show resolved Hide resolved
@goodsong81 goodsong81 merged commit 6f00907 into develop Sep 20, 2023
@goodsong81 goodsong81 deleted the infra/torch2.0 branch September 20, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUILD DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM DOC Improvements or additions to documentation FEATURE New feature & functionality TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants