Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model category attributes to model template #2362

Merged
merged 9 commits into from
Jul 18, 2023

Conversation

goodsong81
Copy link
Contributor

@goodsong81 goodsong81 commented Jul 14, 2023

Summary

  • Add model category fields to specify category, deprecation, default model
model_category: {SPEED|BALANCE|ACCURACY|OTHER}, default to OTHER
model_status: {ACTIVE|DEPRECATED}, defaults to ACTIVE
is_default_for_task: {TRUE|FALSE}, defaults to FALSE
  • Apply current model spec in model templates
    image
    ("Other" models like DeiT is not specified here)

  • Add unit & integration tests

    • Each task should have 1 SPEED & 1 ACCURACY models, and optionally 1 BALANCE models
    • Each task should have 1 default model, which should be ACTIVE and not in OTHER category
    • Deprecated models should be in OTHER category

How to test

  • CI tests

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

Signed-off-by: Songki Choi <songki.choi@intel.com>
Signed-off-by: Songki Choi <songki.choi@intel.com>
@goodsong81 goodsong81 added the FEATURE New feature & functionality label Jul 14, 2023
@goodsong81 goodsong81 added this to the 1.5.0 milestone Jul 14, 2023
@github-actions github-actions bot added API Any changes in OTX API TEST Any changes in tests labels Jul 14, 2023
Signed-off-by: Songki Choi <songki.choi@intel.com>
Signed-off-by: Songki Choi <songki.choi@intel.com>
Signed-off-by: Songki Choi <songki.choi@intel.com>
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Jul 17, 2023
Signed-off-by: Songki Choi <songki.choi@intel.com>
@goodsong81 goodsong81 force-pushed the add/model-type-attr branch from e9fb58c to 2a400b3 Compare July 17, 2023 05:05
@goodsong81 goodsong81 marked this pull request as ready for review July 17, 2023 06:42
@goodsong81 goodsong81 requested a review from a team as a code owner July 17, 2023 06:42
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this PR be merged after Geti side test?

@goodsong81
Copy link
Contributor Author

Will this PR be merged after Geti side test?

This change will not affect Geti's model configurations for now. Rather, Geti will implement new model template loading after this change is merged to Geti.

@jaegukhyun
Copy link
Contributor

Will this PR be merged after Geti side test?

This change will not affect Geti's model configurations for now. Rather, Geti will implement new model template loading after this change is merged to Geti.

Should this PR target release branch?

@goodsong81
Copy link
Contributor Author

Will this PR be merged after Geti side test?

This change will not affect Geti's model configurations for now. Rather, Geti will implement new model template loading after this change is merged to Geti.

Should this PR target release branch?

No, it's not. DeiT is, fortunately, being registered as "Other" model automatically so that we don't need to hurry this change for OTX1.4->Geti1.8. I'm targeting the develop branch on purpose.

sungmanc
sungmanc previously approved these changes Jul 17, 2023
Signed-off-by: Songki Choi <songki.choi@intel.com>
Signed-off-by: Songki Choi <songki.choi@intel.com>
Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! I left some comments. Please take a look.

@goodsong81 goodsong81 merged commit 48989b2 into openvinotoolkit:develop Jul 18, 2023
@goodsong81 goodsong81 deleted the add/model-type-attr branch July 18, 2023 06:54
@sungmanc sungmanc mentioned this pull request Aug 8, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API FEATURE New feature & functionality TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants