-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add model category attributes to model template #2362
Add model category attributes to model template #2362
Conversation
Signed-off-by: Songki Choi <songki.choi@intel.com>
Signed-off-by: Songki Choi <songki.choi@intel.com>
Signed-off-by: Songki Choi <songki.choi@intel.com>
Signed-off-by: Songki Choi <songki.choi@intel.com>
Signed-off-by: Songki Choi <songki.choi@intel.com>
e9fb58c
to
2a400b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this PR be merged after Geti side test?
This change will not affect Geti's model configurations for now. Rather, Geti will implement new model template loading after this change is merged to Geti. |
Should this PR target release branch? |
No, it's not. DeiT is, fortunately, being registered as "Other" model automatically so that we don't need to hurry this change for OTX1.4->Geti1.8. I'm targeting the develop branch on purpose. |
Signed-off-by: Songki Choi <songki.choi@intel.com>
Signed-off-by: Songki Choi <songki.choi@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work! I left some comments. Please take a look.
Summary
Apply current model spec in model templates
("Other" models like DeiT is not specified here)
Add unit & integration tests
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.