Return raw anomaly maps as metadata #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samet-akcay
previously approved these changes
Jun 2, 2023
There was a problem hiding this comment.
Thanks @djdameln! Really appreciate your hard work chasing this bug!
goodsong81
previously approved these changes
Jun 2, 2023
|
What a nice fix ! BTW, "Colormap conversion was applied twice after a recent change on Geti side.", is this only affects to the sailency map part? or only anomaly tasks? I'm just wondering about the side effect of Geti's change to OTX side. |
goodsong81
approved these changes
Jun 2, 2023
Other tasks from OTX were modified earlier, that problem with anomaly is a result of miscommunication. |
sovrasov
approved these changes
Jun 2, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## releases/1.2.3 #2217 +/- ##
==================================================
- Coverage 79.96% 79.96% -0.01%
==================================================
Files 459 459
Lines 33794 33790 -4
==================================================
- Hits 27024 27020 -4
Misses 6770 6770
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
samet-akcay
approved these changes
Jun 2, 2023
goodsong81
pushed a commit
that referenced
this pull request
Jun 2, 2023
* return raw anomaly map instead of colormap * return raw heatmap in openvino inference * Update changelog * convert anomaly map to numpy
goodsong81
added a commit
that referenced
this pull request
Jun 5, 2023
* Fix e2e (#2179) * Fix iseg e2e (#2173) * Fix det e2e (#2176) * Update noisy label det docs for detection task (#2183) * Fix iseg e2e (#2173) * Fix det e2e (#2176) * Add supcon seg for regression (#2177) * Fix iseg e2e (#2173) * Fix det e2e (#2176) * Update regression test config (#2186) * Fix for anomaly regression test (#2188) * Fix iseg regression (#2190) * Set path to save pseudo masks into workspace (#2185) * Temporary fix override_configs bug (#2187) * Fix iseg e2e (#2173) * Fix det e2e (#2176) * Cleaned up skip/xfail TCs on the classification e2e tests (#2196) * Added csv output to export dependencies (#2178) * Fix typo and enlarge the threshold for KPI tests (#2198) * bugfix: auto adapt batch size doesn't work with cls incr case (#2199) * Fix for ssd (#2197) * Turn off persistent worker if num_worker is zero in classification task (#2208) * Update test cases of common_semantic_segmentation_dataset (#2210) * Optimize counting train & inference speed and memory consumption (#2172) * Do not skip full img tile classifier + Fix Sequencial Export Issue (#2174) * Add warning message to tiling parameter (#2193) * Change the way to pad for instance-segmentation * Hotfix: use 0 confidence threshold when computing best threshold based on F1 * Fix possible bw issue in exportable code (#2212) * Fix ellipse load (#2214) * Fix GT vs prediction order mismatch due to different sorting result (#2216) * Return raw anomaly maps as metadata (#2217) * Fix merge error, revert to pymongo w/o version spec --------- Signed-off-by: Songki Choi <songki.choi@intel.com> Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com> Co-authored-by: Jaeguk Hyun <jaeguk.hyun@intel.com> Co-authored-by: Vinnam Kim <vinnam.kim@intel.com> Co-authored-by: Sungman Cho <sungman.cho@intel.com> Co-authored-by: Eunwoo Shin <eunwoo.shin@intel.com> Co-authored-by: Kim, Sungchul <sungchul.kim@intel.com> Co-authored-by: Yunchu Lee <yunchu.lee@intel.com> Co-authored-by: Jihwan Eom <jihwan.eom@intel.com> Co-authored-by: Eugene Liu <eugene.liu@intel.com> Co-authored-by: sungmanc <sungmanc@intel.com> Co-authored-by: Vladislav Sovrasov <sovrasov.vlad@gmail.com> Co-authored-by: Dick Ameln <dick.ameln@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for https://jira.devtools.intel.com/browse/CVS-112271
Colormap conversion was applied twice after a recent change on Geti side. This PR fixes this by removing the color conversion on OTX side and passing the raw anomaly map instead.
How to test
See details in JIRA ticket.
Checklist
License
Feel free to contact the maintainers if that's a concern.