Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e #2179

Merged
merged 2 commits into from
May 23, 2023
Merged

Fix e2e #2179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b26b6dd
Fix iseg e2e (#2173)
jaegukhyun May 22, 2023
25b8776
Fix det e2e (#2176)
jaegukhyun May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion otx/algorithms/detection/configs/detection/cspdarknet_yolox/data_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
img_scale=(416, 416),
flip=False,
transforms=[
dict(type="Resize", keep_ratio=False),
dict(type="Resize", keep_ratio=True),
dict(type="RandomFlip"),
dict(type="Pad", size=(416, 416), pad_val=114.0),
dict(type="Normalize", **__img_norm_cfg),
Expand Down
3 changes: 2 additions & 1 deletion otx/api/configuration/helper/convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@


from enum import Enum
from typing import Type, TypeVar
from typing import Any, Type, TypeVar

import yaml
from omegaconf import DictConfig, OmegaConf
Expand Down Expand Up @@ -128,6 +128,7 @@ def convert(
config_id = config_dict.get("id", None)
config_dict["id"] = str(config_id) if config_id is not None else None

result: Any = None
if target == str:
result = yaml.dump(config_dict)
elif target == dict:
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/cli/detection/test_detection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"--val-data-roots": "tests/assets/car_tree_bug",
"--test-data-roots": "tests/assets/car_tree_bug",
"--input": "tests/assets/car_tree_bug/images/train",
"train_params": ["params", "--learning_parameters.num_iters", "6", "--learning_parameters.batch_size", "4"],
"train_params": ["params", "--learning_parameters.num_iters", "15", "--learning_parameters.batch_size", "4"],
}

# Class-Incremental learning w/ 'vehicle', 'person', 'non-vehicle' classes
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/cli/instance_segmentation/test_instance_segmentation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"--val-data-roots": "tests/assets/car_tree_bug",
"--test-data-roots": "tests/assets/car_tree_bug",
"--input": "tests/assets/car_tree_bug/images/train",
"train_params": ["params", "--learning_parameters.num_iters", "4", "--learning_parameters.batch_size", "2"],
"train_params": ["params", "--learning_parameters.num_iters", "5", "--learning_parameters.batch_size", "2"],
}

# Training params for resume, num_iters*2
Expand Down