Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize adaptive tiling #2164

Closed
wants to merge 8 commits into from
Closed

Optimize adaptive tiling #2164

wants to merge 8 commits into from

Conversation

goodsong81
Copy link
Contributor

@goodsong81 goodsong81 commented May 17, 2023 •
edited
Loading

Summary

  • Refine adaptive tiling parameter logic
  • Area -> size for ratio computation
  • Tune object-tile ratio: 16x16 object in 512x512 model -> 16/512 = 0.3
  • Fix overlap_ratio in IR inference according to IR scale factor
  • Apply edge fix from @eugene123tw
  • Apply 512x512 size as default for tiling
  • Add logs for debugging
  • Fix config patching
  • Temporary torch 1.12.1

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

goodsong81 and others added 4 commits May 17, 2023 17:52
@goodsong81
Refine adaptive tile params
a0b9cd2 
- Use size rather than area
- 32 pixels as min detectable size
- Default object_tile_ratio = 32 / 1024 = 0.03
@goodsong81
Tune params
13d775f
@eugene123tw @goodsong81
Fix tile on the edge
e96800a
@goodsong81
Fix IR overlap ratio according to IR scale factor
82ee985 
Signed-off-by: Songki Choi <songki.choi@intel.com>
@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API BUILD labels May 17, 2023
@sungmanc sungmanc mentioned this pull request May 22, 2023
Merged
8 tasks
@goodsong81 goodsong81 closed this May 23, 2023
@goodsong81 goodsong81 deleted the songkich/optimize-adaptive-tiling branch May 23, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugene123tw eugene123tw Awaiting requested review from eugene123tw

@sungmanc sungmanc Awaiting requested review from sungmanc

@jaegukhyun jaegukhyun Awaiting requested review from jaegukhyun

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API BUILD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goodsong81 @eugene123tw