Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add training loss dynamics exportation feature for detection task #2109

Merged
merged 4 commits into from
May 12, 2023

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented May 4, 2023

Summary

  • Ticket no. 93287
  • Add training loss dynamics exportation feature for detection task.
  • This PR only supports CustomATSS detector. Following up PRs will cover other models.

How to test

I added unit tests about this change.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

vinnamkim added 2 commits May 4, 2023 11:13
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API TEST Any changes in tests labels May 4, 2023
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review May 4, 2023 11:46
@vinnamkim vinnamkim requested a review from a team as a code owner May 4, 2023 11:46
@vinnamkim vinnamkim marked this pull request as draft May 4, 2023 11:47
@vinnamkim vinnamkim changed the title Vinnamki/feature/noisy label detection det Add training loss dynamics exportation feature for detection task May 4, 2023
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2023

Codecov Report

Patch coverage: 95.47% and project coverage change: +0.33 🎉

Comparison is base (63d9d7a) 79.55% compared to head (0a595b6) 79.89%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2109      +/-   ##
===========================================
+ Coverage    79.55%   79.89%   +0.33%     
===========================================
  Files          462      464       +2     
  Lines        34124    34325     +201     
===========================================
+ Hits         27149    27424     +275     
+ Misses        6975     6901      -74     
Flag Coverage Δ
py310 79.89% <95.47%> (+0.33%) ⬆️
py38 ?
py39 79.88% <95.47%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ithms/detection/adapters/mmdet/models/loss_dyns.py 77.27% <77.27%> (ø)
otx/core/data/noisy_label_detection/base.py 89.28% <90.00%> (-1.20%) ⬇️
...on/adapters/mmdet/models/heads/custom_atss_head.py 92.39% <95.65%> (+67.05%) ⬆️
...ication/adapters/mmcls/models/classifiers/mixin.py 96.55% <100.00%> (-0.17%) ⬇️
...ithms/detection/adapters/mmdet/datasets/dataset.py 94.36% <100.00%> (+0.12%) ⬆️
...dapters/mmdet/datasets/pipelines/load_pipelines.py 89.36% <100.00%> (+0.23%) ⬆️
...ers/mmdet/models/detectors/custom_atss_detector.py 67.56% <100.00%> (+1.81%) ⬆️
...ters/mmdet/models/detectors/loss_dynamics_mixin.py 100.00% <100.00%> (ø)
otx/algorithms/detection/adapters/mmdet/task.py 85.42% <100.00%> (+1.05%) ⬆️
...hms/detection/adapters/mmdet/utils/config_utils.py 91.82% <100.00%> (-1.96%) ⬇️
... and 3 more

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinnamkim vinnamkim marked this pull request as ready for review May 4, 2023 14:37
@vinnamkim vinnamkim requested a review from wonjuleee May 8, 2023 01:02
@goodsong81 goodsong81 added this to the 1.3.0 milestone May 8, 2023
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jaegukhyun jaegukhyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall codes look good to me. Since I'm not familiar with loss dynamics, I don't closely look at the algorithm in detail. I wish I could review it after introduction meeting. And I want to suggest to move config patch parts to existed patch function and configurer.

Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinnamkim vinnamkim merged commit 1ece09e into develop May 12, 2023
@vinnamkim vinnamkim deleted the vinnamki/feature/noisy-label-detection-det branch May 12, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants