-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add training loss dynamics exportation feature for detection task #2109
Add training loss dynamics exportation feature for detection task #2109
Conversation
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2109 +/- ##
===========================================
+ Coverage 79.55% 79.89% +0.33%
===========================================
Files 462 464 +2
Lines 34124 34325 +201
===========================================
+ Hits 27149 27424 +275
+ Misses 6975 6901 -74
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall codes look good to me. Since I'm not familiar with loss dynamics, I don't closely look at the algorithm in detail. I wish I could review it after introduction meeting. And I want to suggest to move config patch parts to existed patch function and configurer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
CustomATSS
detector. Following up PRs will cover other models.How to test
I added unit tests about this change.
Checklist
License
Feel free to contact the maintainers if that's a concern.