Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeiT template for OTX classification task #2093

Merged
merged 27 commits into from
May 16, 2023

Conversation

JihwanEom
Copy link
Contributor

@JihwanEom JihwanEom commented May 1, 2023

Summary

  • Add DeiT template for multi-class classification task
  • Support multi-label, hierarchical label
  • Support incremental learning (ignore label)
  • Support semi-supervised learning
  • Pass unit tests
  • Pass integration tests
  • Pass E2E tests except explain, self-sl, supcon
  • Validate HPO operations
  • Update CHANGELOG
  • Write unit tests

Future works (will be dealt in other PR)

  • Optimize multi-label/h-label training recipe
  • Update documentation -> Will be updated when promoting as regular template for OTX (not experimental)
  • Support NNCF (resolve FQ issue)
  • Support explain CLI
  • Support self-supervised learning
  • Support supcon

FQ issue in e2e test -> missing compression.json used for NNCF task, currently skipping TC:

FAILED tests/e2e/cli/classification/test_classification.py::TestToolsMultiClassClassification::test_pot_validate_fq[Custom_Image_Classification_deit-tiny] AssertionError: Reference file does not exist: /home/cosmos/ws/otx-vit/tests/e2e/cli/classification/reference/Custom_Image_Classification_deit-tiny/compressed_model.yml [num_fq = 137]
FAILED tests/e2e/cli/classification/test_classification.py::TestToolsMultilabelClassification::test_pot_validate_fq[Custom_Image_Classification_deit-tiny] AssertionError: Reference file does not exist: /home/cosmos/ws/otx-vit/tests/e2e/cli/classification/reference/Custom_Image_Classification_deit-tiny/compressed_model.yml [num_fq = 137]
FAILED tests/e2e/cli/classification/test_classification.py::TestToolsHierarchicalClassification::test_pot_validate_fq[Custom_Image_Classification_deit-tiny] AssertionError: Reference file does not exist: /home/cosmos/ws/otx-vit/tests/e2e/cli/classification/reference/Custom_Image_Classification_deit-tiny/compressed_model.yml [num_fq = 137]

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label May 1, 2023
@JihwanEom JihwanEom changed the title Add DeiT template for OTX multi-class classification task Add DeiT template for OTX classification task May 1, 2023
@github-actions github-actions bot added BUILD TEST Any changes in tests labels May 2, 2023
@github-actions github-actions bot removed the BUILD label May 3, 2023
@github-actions github-actions bot added the DOC Improvements or additions to documentation label May 4, 2023
@JihwanEom JihwanEom marked this pull request as ready for review May 4, 2023 06:47
@JihwanEom JihwanEom requested a review from a team as a code owner May 4, 2023 06:47
Copy link
Contributor

@jaegukhyun jaegukhyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Could we avoid class.name?

Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jaegukhyun jaegukhyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your effort! This could be a great start to join transformer to OTX

@JihwanEom JihwanEom enabled auto-merge (squash) May 16, 2023 06:58
@JihwanEom JihwanEom merged commit 834fc8f into openvinotoolkit:develop May 16, 2023
@JihwanEom JihwanEom deleted the jeom/vit-template branch May 20, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants