Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused modules in semantic segmentation (release) #2068

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Remove unused modules in semantic segmentation (release) #2068

merged 3 commits into from
Apr 25, 2023

Conversation

supersoob
Copy link
Contributor

@supersoob supersoob commented Apr 25, 2023 •
edited
Loading

Summary

I removed unused modules in semantic segmentation such as mixin.py.
While replacing to new ignore loss, I found that modules in mixin is not using actually.
Current logic does not require any modules in mixin, removed them.

Optimization for segmentation

  • (DONE) sampler change
  • (DONE) MaskCompose remove
  • (DONE) repeated ckpt loading remove
  • (DONE) Ignored loss function
  • (In review) refactoring
  • (WIP) Enable num_workers for dataloading

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

supersoob and others added 3 commits April 25, 2023 13:09
@supersoob @harimkang
@eugene123tw @sungmanc @goodsong81 @yunchu @jaegukhyun @cih9088 @eunwoosh
Integrate new ignored loss in semantic segmentation (openvinotoolkit#…
248521c 
…2055)

* HOT-FIX: Revert segmentation model's ignore mode in CLI (openvinotoolkit#2011)

Revert segmentation ignore=True

* Improve tiling preprocess (openvinotoolkit#2013)

* prevent timeout during init phase

* Fix reg tests (openvinotoolkit#2008)

* Edit regression tests

* Change the dataset root

* Miss typo

* Fix pre-commit

* Fix openvino import error due to Tiler init import (openvinotoolkit#2015)

Remove init import for Tiler to prevent OpenVINO import

* Bump up version to 1.2.0 (openvinotoolkit#2017)

* Set the python version to "3.10" for code-scan workflow

* Add missing __init__.py (openvinotoolkit#2019)

* Add missing __init__.py

* Change license

* Release 1.2.0rc1

* Fix issue that str2bool not being applied in certain cases (openvinotoolkit#2023)

* Add workaround solution

* Fix minor

* Remove str int

* Fix default dict (openvinotoolkit#2025)

fix: change default to configdict

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>

* Convert dummy datasets to toy datasets (openvinotoolkit#1988)

* Update cls, det datsets

* Remove useless files

* Change action datasets

* Edit action dataset

* change dir

* Add xml files

* Remove useless

* Edite tets

* Fix tests

* Fix tests

* Remove ptc

* Remove

* Fix precommit

* Update dataset, fix cls bug

* Remove useless dataset

* Edit drop_last

* Fix missed part

* Change threshold values to unifying

* bugfix: squeezing to 1 dimenetion

* Change threshold for deployment

* Fix multi-gpu issue, e2e tests

* Decrease num_workers for tiling test and tiling processes

* Revert num_workers for tests

* Fix datsets

---------

Co-authored-by: eunwoosh <eunwoo.shin@intel.com>

* Fix E2E tests (openvinotoolkit#2032)

* Optimize data preprocessing time and enhance overall performance in semantic segmentation (openvinotoolkit#2020)

* add unit test

* exp

* intg agg

* implement ignore label

* no update in model.py

* ignore in label

* only updated ignored loss

* final

* final

* exp

* refactor

* refactor ignore loss

* revert

* default mode is ignore false

* unit test revised

* model update

* revise detcon

* fix error in intg test

* test case revised

* make run in semisl

* add type hints

* update docs

* test case added

---------

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Co-authored-by: Harim Kang <harim.kang@intel.com>
Co-authored-by: Eugene Liu <eugene.liu@intel.com>
Co-authored-by: Sungman Cho <sungman.cho@intel.com>
Co-authored-by: Songki Choi <songki.choi@intel.com>
Co-authored-by: Yunchu Lee <yunchu.lee@intel.com>
Co-authored-by: Jaeguk Hyun <jaeguk.hyun@intel.com>
Co-authored-by: Inhyuk Cho <andy.inhyuk.jo@intel.com>
Co-authored-by: eunwoosh <eunwoo.shin@intel.com>
Co-authored-by: Lee, Soobee <soobeele@intel.com>
@supersoob
Merge branch 'releases/1.2.1' of https://github.com/openvinotoolkit/t…
6c28cc3 
…raining_extensions into releases/1.2.1
@supersoob
remove all mixin modules
6d051b8
@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests labels Apr 25, 2023
@supersoob supersoob marked this pull request as ready for review April 25, 2023 07:16
@supersoob supersoob requested a review from a team as a code owner April 25, 2023 07:16
@supersoob supersoob added this to the 1.2.0 milestone Apr 25, 2023
@supersoob supersoob enabled auto-merge (squash) April 25, 2023 07:52
@supersoob supersoob merged commit 53d5157 into openvinotoolkit:releases/1.2.1 Apr 25, 2023
goodsong81 pushed a commit to goodsong81/training_extensions that referenced this pull request Apr 27, 2023
@supersoob @goodsong81
Remove unused modules in semantic segmentation (openvinotoolkit#2068)
1608b9f
goodsong81 added a commit that referenced this pull request May 3, 2023
@goodsong81 @eunwoosh
@supersoob @cih9088 @eugene123tw @harimkang @jaegukhyun
Merge back 1.2.1 RC1 & RC2 (#2086)
a1f098d 
* Upgrade mmdeploy==0.14.0 from official PyPI (#2047)

* Bug fix: value of validation variable is changed after auto decrease batch size (#2053)

* Integrate new ignored loss in semantic segmentation (#2065)

* Remove unused modules in semantic segmentation (#2068)

* Add doc for fast data loading (#2069)

* Bug fix: set gpu_ids properly (#2071)

* Bug fix: Progress goes 100% and back 0 % repeatedly during auto decrease bs in Geti (#2074)

* Fix tiling 0 stride issue in parameter adapter (#2078)

* Update instance-segmentation tutorial documentation (#2082)

* Optimize YOLOX data pipeline and add unit test for get_subset of Datu… (#2075)

* Tiling Spatial Concatenation for OpenVINO IR (#2052)

* Add spatial concatenation to deployment demo (#2089)

---------

Signed-off-by: Songki Choi <songki.choi@intel.com>
Co-authored-by: Eunwoo Shin <eunwoo.shin@intel.com>
Co-authored-by: Soobee Lee <soobee.lee@intel.com>
Co-authored-by: Inhyuk Cho <andy.inhyuk.jo@intel.com>
Co-authored-by: Eugene Liu <eugene.liu@intel.com>
Co-authored-by: Harim Kang <harim.kang@intel.com>
Co-authored-by: Jaeguk Hyun <jaeguk.hyun@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eunwoosh eunwoosh eunwoosh approved these changes

@sungmanc sungmanc sungmanc approved these changes

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation REFACTOR RELEASE TEST Any changes in tests
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@supersoob @sungmanc @eunwoosh