Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration to segmentation IR #2029

Merged
merged 6 commits into from
Apr 24, 2023

Conversation

sovrasov
Copy link
Contributor

@sovrasov sovrasov commented Apr 18, 2023

Summary

This PR adds ModelAPI-specific meta information into segmentation model IR.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@sovrasov sovrasov requested review from Wovchena and AlexKoff88 April 18, 2023 14:44
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Apr 18, 2023
AlexKoff88
AlexKoff88 previously approved these changes Apr 19, 2023
@github-actions github-actions bot added the TEST Any changes in tests label Apr 19, 2023
@sovrasov sovrasov marked this pull request as ready for review April 19, 2023 10:42
@sovrasov sovrasov requested a review from a team as a code owner April 19, 2023 10:42
@github-actions github-actions bot added the DOC Improvements or additions to documentation label Apr 19, 2023
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Embedding itself here looks OK to me.
Would you somehow check whether the IR models from old OTX (Geti) without this segmentation metadata will be still working well without issues? I mean backward compatibility.

@sovrasov
Copy link
Contributor Author

Embedding itself here looks OK to me. Would you somehow check whether the IR models from old OTX (Geti) without this segmentation metadata will be still working well without issues? I mean backward compatibility.

This information is not used by OTX, so such issues can not arise (like we don't observe it in case of classification and detection).

@goodsong81
Copy link
Contributor

Embedding itself here looks OK to me. Would you somehow check whether the IR models from old OTX (Geti) without this segmentation metadata will be still working well without issues? I mean backward compatibility.

This information is not used by OTX, so such issues can not arise (like we don't observe it in case of classification and detection).

Yes, I agree. When the new ModelAPIs will replace current OMZ ModelAPIs, we need to check such compatibility anyway. Thank you for clarification. :)

@sovrasov sovrasov requested a review from kprokofi April 20, 2023 11:39
@sovrasov
Copy link
Contributor Author

sovrasov commented Apr 20, 2023

Embedding itself here looks OK to me. Would you somehow check whether the IR models from old OTX (Geti) without this segmentation metadata will be still working well without issues? I mean backward compatibility.

This information is not used by OTX, so such issues can not arise (like we don't observe it in case of classification and detection).

Yes, I agree. When the new ModelAPIs will replace current OMZ ModelAPIs, we need to check such compatibility anyway. Thank you for clarification. :)

yeah, integration of ModelAPI and it's consequences for geti versions compatibility is a standalone discussion. It's complicated, since MAPI doesn't know about config.json, so we may need patch IRs in a JIT manner.

@sovrasov sovrasov merged commit 2a05810 into openvinotoolkit:develop Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants