-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration to segmentation IR #2029
Conversation
681ead6
to
d2f21cc
Compare
d2f21cc
to
998ba7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Embedding itself here looks OK to me.
Would you somehow check whether the IR models from old OTX (Geti) without this segmentation metadata will be still working well without issues? I mean backward compatibility.
This information is not used by OTX, so such issues can not arise (like we don't observe it in case of classification and detection). |
Yes, I agree. When the new ModelAPIs will replace current OMZ ModelAPIs, we need to check such compatibility anyway. Thank you for clarification. :) |
yeah, integration of ModelAPI and it's consequences for geti versions compatibility is a standalone discussion. It's complicated, since MAPI doesn't know about config.json, so we may need patch IRs in a JIT manner. |
Summary
This PR adds ModelAPI-specific meta information into segmentation model IR.
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.