Add --output parameter to demo to save results
#2005
Conversation
e7e7da2 to
8c11c3d
Compare
|
Actually, do I understand correctly, that this parameter doesn't require adding extra tests? |
docs/source/guide/get_started/quick_start_guide/cli_commands.rst
Outdated
Show resolved
Hide resolved
| @@ -39,12 +39,13 @@ def run(self, input_stream: Union[int, str], loop: bool = False) -> None: | |||
| next_frame_id_to_show = 0 | |||
| stop_visualization = False | |||
|
|
|||
| for frame in streamer: | |||
| for (frame, input_path) in streamer: | |||
There was a problem hiding this comment.
I think it can raise an error if streamer is ThreadStreamer.
There was a problem hiding this comment.
We can stick to a pre-defined output video/images names to avoid introducing the additional output from streamer.
There was a problem hiding this comment.
Sure, it will be much easier. But it would cause a problem, that input and output names aren't consistent and it's hard to identify, which image was the source, based on naming
But if additional output in streamer is highly unwelcome, I can write a standalone function to get input names from args.input, without changing the streamer code.
docs/source/guide/get_started/quick_start_guide/cli_commands.rst
Outdated
Show resolved
Hide resolved
| @@ -39,12 +39,13 @@ def run(self, input_stream: Union[int, str], loop: bool = False) -> None: | |||
| next_frame_id_to_show = 0 | |||
| stop_visualization = False | |||
|
|
|||
| for frame in streamer: | |||
| for (frame, input_path) in streamer: | |||
There was a problem hiding this comment.
We can stick to a pre-defined output video/images names to avoid introducing the additional output from streamer.
save-results-to parameter to demo --output parameter to demo to save results
|
@eunwoosh @harimkang @sovrasov Thank you for your very useful comments. I removed extra output for the streamer and moved logic for saving images to one function in utils that CLI demo and exportable code demo share between each other. @sovrasov I updated the exportable code README according to the latest CLI changes and customer feedback. The rest of the changes with exportable code from the feedback will be added in a separate PR to speed up the review of this one. |
| if isinstance(input_path, int): | ||
| return [] | ||
| if "DIR" in capture.get_type(): | ||
| return [f.name for f in Path(input_path).iterdir() if f.is_file()] |
There was a problem hiding this comment.
It's for DirStreamer right? Then, I think this and that in DirStreamer should have same order.
I think one way to ensure that is a making a function to make a list of files in directory and make both of them use it.
There was a problem hiding this comment.
I'm sorry, I didn't quite understand you. Can you please elaborate?
There was a problem hiding this comment.
As far as I understand, function get_input_names_list is in charge of providing list of names to save the frames.
And if "DIR" in capture.get_type(): is for the case where DirStreamer is used. The problem is that each frame doesn't have information about which file is used for current frame in that case. So, when saving the frame, get filenames by [f.name for f in Path(input_path).iterdir() if f.is_file()] and then using each file name iterating zip(filenames, saved_frames).
What I think as problem is an order of [f.name for f in Path(input_path).iterdir() if f.is_file()] in the function and order of sorted(os.listdir(self.dir)) in DirStreamer can be different. So, I think both order of list should be same.
Of course, I may be misunderstanding. then I really appreciate if you let me know :)
Sure, I'll add tests on Monday in this PR or in the separate PR (if we'll be able to merge it today) |
Summary
--save-results-toparameter.It helps to keep and check the inference results after running a demo, using the command line on a remote station, without the necessity to use X server.
Jira ticket: https://jira.devtools.intel.com/browse/CVS-107856
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.