Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split export function and _export_model function for detection task #1997

Merged
merged 5 commits into from
Apr 12, 2023

Conversation

jaegukhyun
Copy link
Contributor

@jaegukhyun jaegukhyun commented Apr 11, 2023

Summary

For sync with other task(cls, seg) export function for detection task, export function should be splitted into export function and _export_model function.
In addition, in this PR, I added basic unit test for covering MMDetectionTask and OTXDetectionTask.

How to test

normal cli, unit test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Apr 11, 2023
@github-actions github-actions bot added TEST Any changes in tests DOC Improvements or additions to documentation labels Apr 11, 2023
@jaegukhyun jaegukhyun marked this pull request as ready for review April 11, 2023 10:48
@jaegukhyun jaegukhyun requested a review from a team as a code owner April 11, 2023 10:48
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set the proper milestone, and need to resolve a conflict

Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! I left some comments.

@jaegukhyun jaegukhyun force-pushed the det-export-refactoring branch from 50436fc to 7385752 Compare April 12, 2023 01:56
@jaegukhyun jaegukhyun added this to the 1.2.0 milestone Apr 12, 2023
@jaegukhyun
Copy link
Contributor Author

Please set the proper milestone, and need to resolve a conflict

Done.

eunwoosh
eunwoosh previously approved these changes Apr 12, 2023
sungmanc
sungmanc previously approved these changes Apr 12, 2023
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaegukhyun jaegukhyun dismissed stale reviews from sungmanc and eunwoosh via 68e9f27 April 12, 2023 03:32
@jaegukhyun jaegukhyun requested review from sungmanc and eunwoosh April 12, 2023 05:47
@jaegukhyun jaegukhyun merged commit 10fce79 into openvinotoolkit:develop Apr 12, 2023
@jaegukhyun jaegukhyun deleted the det-export-refactoring branch June 2, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants