-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split export function and _export_model function for detection task #1997
Split export function and _export_model function for detection task #1997
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please set the proper milestone, and need to resolve a conflict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work! I left some comments.
50436fc
to
7385752
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
For sync with other task(cls, seg) export function for detection task, export function should be splitted into export function and _export_model function.
In addition, in this PR, I added basic unit test for covering MMDetectionTask and OTXDetectionTask.
How to test
normal cli, unit test
Checklist
License
Feel free to contact the maintainers if that's a concern.