Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ANOMALY] Add DRAEM task implementation #1203

Merged
merged 36 commits into from
Aug 11, 2022
Merged

[ANOMALY] Add DRAEM task implementation #1203

merged 36 commits into from
Aug 11, 2022

Conversation

djdameln
Copy link
Contributor

@djdameln djdameln commented Aug 9, 2022 •
edited
Loading

This PR adds the task files for the DRAEM model. The transform config location had to be hard-coded, this probably needs to be changed later on.
Screenshot from 2022-08-09 14-45-34

Ashwin Vaidya and others added 30 commits July 14, 2022 14:24
Add initial support for anomalib 0.3.3
41e245e
Refactor directory structure
2dd51ea
revert path
ee1451b
🚚 Move python configs
fa206b7
Replace LabelNames with is_anomalous
71ea064
Rename model_config_path to config_path
ba44ef6
🚚 Move tasks from tools to root
e79587d
Refactor configs
cad5502
@ashwinvaidya17
🚚 refactor templates + configs structure
ba4ee94
@ashwinvaidya17
Upgrade torch version
aa33c1f
@ashwinvaidya17
Merge branch 'develop' into ashwin/upgrade_anomalib
e0e34f8
@ashwinvaidya17
fix url
a861026
@ashwinvaidya17
Update template paths + add nncf to requirements
237a2ee
@ashwinvaidya17
Update label mapper
d16716a
@ashwinvaidya17
Fix nncf task + address tests
d71f91e
@ashwinvaidya17
Revert to previous torch version + add torchtext dependency
c8adf78
@ashwinvaidya17
Upgrade anomalib version
5f29f13
@ashwinvaidya17
Merge branch 'develop' into ashwin/upgrade_anomalib
15b3fd9
@ashwinvaidya17
Revert torchtext removal
317aa81
@ashwinvaidya17
Fix openvino inference
9388114
@ashwinvaidya17
Upgrade to 0.3.5
f1e9711
@ashwinvaidya17
Rename task
8c4adb1
@ashwinvaidya17
Limit pytorch lightning versio
abbc16d
@djdameln
add config files and templates for Draem model
314a10e
@djdameln
formatting
25ec05c
@djdameln
properly load transform config
6e2cb9d
@djdameln
remove backbone parameter from base config
d900f3e
@djdameln
rebase
fdb7843
@djdameln
set transform in config adapter instead of data adapter
4fd3866
@djdameln
fix transform config
c6fd106
@djdameln djdameln requested a review from a team as a code owner August 9, 2022 12:48
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Aug 9, 2022
@djdameln
Copy link
Contributor Author

djdameln commented Aug 9, 2022

run ote-test

ashwinvaidya17
ashwinvaidya17 previously approved these changes Aug 9, 2022
View reviewed changes
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The changes look good to me.

samet-akcay
samet-akcay reviewed Aug 9, 2022
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great to see this implemented!

external/anomaly/configs/draem/__init__.py Outdated Show resolved Hide resolved
goodsong81
goodsong81 suggested changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change template.yaml into template_experimental.yaml if it's not intended for SC1.2 feature?

goodsong81
goodsong81 approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@samet-akcay samet-akcay merged commit 1d54006 into develop Aug 11, 2022
@samet-akcay samet-akcay deleted the da/anomaly-draem-model branch August 11, 2022 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samet-akcay samet-akcay samet-akcay approved these changes

@goodsong81 goodsong81 goodsong81 approved these changes

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 left review comments

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djdameln @goodsong81 @ashwinvaidya17 @samet-akcay