Update code feedbacks

tests/conftest.py

@@ -94,7 +94,7 @@ def pytest_addoption(parser: pytest.Parser):
     )
     parser.addoption(
         "--deterministic",
-        action="store",
+        choices=["true", "false"],
         default=None,
         help="Turn on deterministic training (true/false).",
     )

tests/perf/conftest.py

@@ -173,9 +173,12 @@ def fxt_dry_run(request: pytest.FixtureRequest) -> str:
 
 
 @pytest.fixture(scope="session")
-def fxt_deterministic(request: pytest.FixtureRequest) -> str:
+def fxt_deterministic(request: pytest.FixtureRequest) -> bool:
     """Option to turn on deterministic training."""
-    return request.config.getoption("--deterministic")
+    deterministic = request.config.getoption("--deterministic")
+    deterministic = False if deterministic is None else deterministic == "true"
+    log.info(f"{deterministic=}")
+    return deterministic
 
 
 @pytest.fixture(scope="session")

tests/perf/test_action.py

@@ -20,9 +20,8 @@
 def fxt_deterministic(request: pytest.FixtureRequest) -> bool:
     """Override the deterministic setting for action classification task."""
     deterministic = request.config.getoption("--deterministic")
-    deterministic = True if deterministic is None else deterministic.lower() == "true"
-    msg = f"deterministic={deterministic}"
-    log.info(msg)
+    deterministic = True if deterministic is None else deterministic == "true"
+    log.info(f"{deterministic=}")
     return deterministic
 
 

tests/perf/test_anomaly.py

@@ -5,7 +5,6 @@
 
 from __future__ import annotations
 
-import logging
 from pathlib import Path
 from typing import ClassVar
 
@@ -14,18 +13,6 @@
 from .benchmark import Benchmark
 from .conftest import PerfTestBase
 
-log = logging.getLogger(__name__)
-
-
-@pytest.fixture(scope="session")
-def fxt_deterministic(request: pytest.FixtureRequest) -> bool:
-    """Override the deterministic setting for anomaly tasks."""
-    deterministic = request.config.getoption("--deterministic")
-    deterministic = False if deterministic is None else deterministic.lower() == "true"
-    msg = f"deterministic={deterministic}"
-    log.info(msg)
-    return deterministic
-
 
 class TestPerfAnomalyClassification(PerfTestBase):
     """Benchmark anomaly classification."""

tests/perf/test_classification.py

@@ -20,9 +20,8 @@
 def fxt_deterministic(request: pytest.FixtureRequest) -> bool:
     """Override the deterministic setting for classification tasks."""
     deterministic = request.config.getoption("--deterministic")
-    deterministic = True if deterministic is None else deterministic.lower() == "true"
-    msg = f"deterministic={deterministic}"
-    log.info(msg)
+    deterministic = True if deterministic is None else deterministic == "true"
+    log.info(f"{deterministic=}")
     return deterministic
 
 

tests/perf/test_detection.py

@@ -20,9 +20,8 @@
 def fxt_deterministic(request: pytest.FixtureRequest) -> bool:
     """Override the deterministic setting for detection task."""
     deterministic = request.config.getoption("--deterministic")
-    deterministic = True if deterministic is None else deterministic.lower() == "true"
-    msg = f"deterministic={deterministic}"
-    log.info(msg)
+    deterministic = True if deterministic is None else deterministic == "true"
+    log.info(f"{deterministic=}")
     return deterministic
 
 

tests/perf/test_instance_segmentation.py

@@ -5,26 +5,13 @@
 
 from __future__ import annotations
 
-import logging
 from pathlib import Path
 
 import pytest
 
 from .benchmark import Benchmark
 from .conftest import PerfTestBase
 
-log = logging.getLogger(__name__)
-
-
-@pytest.fixture(scope="session")
-def fxt_deterministic(request: pytest.FixtureRequest) -> bool:
-    """Override the deterministic setting for instance segmentation task."""
-    deterministic = request.config.getoption("--deterministic")
-    deterministic = False if deterministic is None else deterministic.lower() == "true"
-    msg = f"deterministic={deterministic}"
-    log.info(msg)
-    return deterministic
-
 
 class TestPerfInstanceSegmentation(PerfTestBase):
     """Benchmark instance segmentation."""

tests/perf/test_semantic_segmentation.py

@@ -5,26 +5,13 @@
 
 from __future__ import annotations
 
-import logging
 from pathlib import Path
 
 import pytest
 
 from .benchmark import Benchmark
 from .conftest import PerfTestBase
 
-log = logging.getLogger(__name__)
-
-
-@pytest.fixture(scope="session")
-def fxt_deterministic(request: pytest.FixtureRequest) -> bool:
-    """Override the deterministic setting for semantic segmentation task."""
-    deterministic = request.config.getoption("--deterministic")
-    deterministic = False if deterministic is None else deterministic.lower() == "true"
-    msg = f"deterministic={deterministic}"
-    log.info(msg)
-    return deterministic
-
 
 class TestPerfSemanticSegmentation(PerfTestBase):
     """Benchmark semantic segmentation."""

tests/perf/test_visual_prompting.py

@@ -5,26 +5,13 @@
 
 from __future__ import annotations
 
-import logging
 from pathlib import Path
 
 import pytest
 
 from .benchmark import Benchmark
 from .conftest import PerfTestBase
 
-log = logging.getLogger(__name__)
-
-
-@pytest.fixture(scope="session")
-def fxt_deterministic(request: pytest.FixtureRequest) -> bool:
-    """Override the deterministic setting for visual prompting task."""
-    deterministic = request.config.getoption("--deterministic")
-    deterministic = False if deterministic is None else deterministic.lower() == "true"
-    msg = f"deterministic={deterministic}"
-    log.info(msg)
-    return deterministic
-
 
 class TestPerfVisualPrompting(PerfTestBase):
     """Benchmark visual prompting."""