Skip to content

Commit

Permalink
fix: ignore annoying leftover data.yaml
Browse files Browse the repository at this point in the history
  • Loading branch information
cih9088 committed Jan 13, 2023
1 parent a6a3056 commit e9a3994
Show file tree
Hide file tree
Showing 7 changed files with 21 additions and 8 deletions.
8 changes: 6 additions & 2 deletions otx/cli/tools/eval.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,12 @@ def parse_args():
parser = argparse.ArgumentParser()
if not os.path.exists("./template.yaml"):
parser.add_argument("template")
parser.add_argument("--data", required=False, default="./data.yaml")
required = not os.path.exists("./data.yaml")
parser.add_argument("--data", required=False)
parsed, _ = parser.parse_known_args()
required = True
if parsed.data is not None:
assert os.path.exists(parsed.data)
required = False

parser.add_argument(
"--test-ann-files",
Expand Down
8 changes: 6 additions & 2 deletions otx/cli/tools/optimize.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,12 @@ def parse_args():
parser = argparse.ArgumentParser()
if not os.path.exists("./template.yaml"):
parser.add_argument("template")
parser.add_argument("--data", required=False, default="./data.yaml")
required = not os.path.exists("./data.yaml")
parser.add_argument("--data", required=False)
parsed, _ = parser.parse_known_args()
required = True
if parsed.data is not None:
assert os.path.exists(parsed.data)
required = False

parser.add_argument(
"--train-ann-files",
Expand Down
8 changes: 6 additions & 2 deletions otx/cli/tools/train.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,12 @@ def parse_args():
parser = argparse.ArgumentParser()
if not os.path.exists("./template.yaml"):
parser.add_argument("template")
parser.add_argument("--data", required=False, default="./data.yaml")
required = not os.path.exists("./data.yaml")
parser.add_argument("--data", required=False)
parsed, _ = parser.parse_known_args()
required = True
if parsed.data is not None:
assert os.path.exists(parsed.data)
required = False

parser.add_argument(
"--train-ann-files",
Expand Down
2 changes: 1 addition & 1 deletion otx/cli/utils/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def configure_dataset(args):
data_subset_format = {"ann-files": None, "data-roots": None}
data_config = {"data": {subset: data_subset_format.copy() for subset in ("train", "val", "test")}}
data_config["data"]["unlabeled"] = {"file-list": None, "data-roots": None}
if os.path.exists(args.data):
if args.data is not None and os.path.exists(args.data):
with open(args.data, "r", encoding="UTF-8") as stream:
data_config = yaml.safe_load(stream)
stream.close()
Expand Down
1 change: 1 addition & 0 deletions otx/mpa/modules/models/segmentors/pixel_weights_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import torch.nn as nn
from mmseg.core import add_prefix
from mmseg.models.builder import build_loss
from mmseg.ops import resize

from ..losses.utils import LossEqualizer

Expand Down
1 change: 0 additions & 1 deletion otx/mpa/seg/stage.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
#

from mmcv import ConfigDict
from mmcv.runner import load_checkpoint

from otx.algorithms.segmentation.adapters.mmseg.utils.builder import build_segmentor
from otx.mpa.stage import Stage
Expand Down
1 change: 1 addition & 0 deletions tests/integration/cli/segmentation/test_segmentation.py
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ def test_otx_eval(self, template, tmp_dir_path):


args_selfsl = {
"--data": "./data.yaml",
"--train-ann-file": "data/segmentation/custom/annotations/detcon_masks",
"--train-data-roots": "data/segmentation/custom/images/training",
"--input": "data/segmentation/custom/images/training",
Expand Down

0 comments on commit e9a3994

Please sign in to comment.