Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Good First Issue][Bug]: fixed ov::serialize(model) that does not report when file writing fails #29123

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

[Good First Issue][Bug]: fixed ov::serialize(model) that does not report when file writing fails #29123

wants to merge 29 commits into from
+85 −67

Conversation

geeky33
Copy link
Contributor

@geeky33 geeky33 commented Feb 23, 2025

Details:

  • Fixed a bug in serialize.cpp that caused issues with model serialization.
  • Added a test case (WriteInReadOnly) to verify behavior when writing to read-only files.
  • Ensured proper cleanup of generated test files.
  • Updated serialization logic to improve stability.

Tickets:

geeky33 and others added 29 commits January 3, 2025 01:56
@geeky33
Implemented CPU plugin just-in-time emitter for NotEqual operation
f0f82e4
@geeky33
Merge branch 'openvinotoolkit:master' into master
353e043
@geeky33
Merge branch 'openvinotoolkit:master' into master
613904b
@geeky33
Updated jit_eltwise_emitters.cpp
6797eec
@geeky33
Merge branch 'openvinotoolkit:master' into master
25f3506
@geeky33
Updated jit_eltwise_emitters.cpp
6aaea6d
@geeky33
Updated jit_eltwise_emitters.hpp
0507f00
@geeky33
Updated jit_eltwise.cpp
78e5b4d
@geeky33
Merge branch 'openvinotoolkit:master' into master
d06a086
@geeky33
Updated jit_eltwise_emitters.cpp
a55d4e8
@geeky33
Merge branch 'openvinotoolkit:master' into master
9e09cc6
@geeky33
Merge branch 'openvinotoolkit:master' into master
08d10ee
@geeky33
Merge branch 'openvinotoolkit:master' into master
b99b332
@geeky33
Merge branch 'openvinotoolkit:master' into master
76bdacd
@geeky33
Merge branch 'openvinotoolkit:master' into master
323dcea
@geeky33
Merge branch 'openvinotoolkit:master' into master
b9b10b5
@geeky33
Updated jit_eltwise_emitters.cpp
a15b8cb
@geeky33
Updated jit_eltwise_emitters.hpp
32d86d6
@geeky33
Updated jit_eltwise.cpp
d43474a
@geeky33
Merge branch 'openvinotoolkit:master' into master
97f779b
@geeky33
Merge branch 'master' into master
d0bd6cd
@geeky33
Merge branch 'openvinotoolkit:master' into master
f1e27d0
@geeky33
Merge branch 'openvinotoolkit:master' into master
954073f
@geeky33
Merge branch 'openvinotoolkit:master' into master
2993502
@geeky33
Merge branch 'openvinotoolkit:master' into master
0cbdf06
@geeky33
Merge branch 'openvinotoolkit:master' into master
d3aa433
@geeky33
Merge branch 'openvinotoolkit:master' into master
e356fd3
@geeky33
Merge branch 'openvinotoolkit:master' into master
b2b5391
@geeky33
Fixed serialization issue in OpenVINO model saving
3771743
@geeky33 geeky33 requested a review from a team as a code owner February 23, 2025 18:08
@geeky33 geeky33 requested a review from a team as a code owner February 23, 2025 18:08
@geeky33 geeky33 requested review from itikhono and removed request for a team February 23, 2025 18:08
@github-actions github-actions bot added the category: Core OpenVINO Core (aka ngraph) label Feb 23, 2025
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Feb 23, 2025
@mlukasze mlukasze linked an issue Feb 24, 2025 that may be closed by this pull request
[Good First Issue][Bug]: ov::serialize(model) does not report when file writing fails #23190
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itikhono itikhono Awaiting requested review from itikhono itikhono is a code owner automatically assigned from openvinotoolkit/openvino-ie-transformations-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph) ExternalPR External contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Good First Issue][Bug]: ov::serialize(model) does not report when file writing fails
2 participants
@geeky33 @sys-openvino-ci