[AUTO] Fix too much memory cost in auto #27871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75e47d7 to
d8f0729
Compare
olpipi
reviewed
Dec 13, 2024
Comment on lines
+664
to
+670
| std::string compute_hash(const std::shared_ptr<const ov::Model>& model, | ||
| const std::string& device_name, | ||
| const ov::AnyMap& properties); | ||
| std::string compute_hash(const std::string& model_path, | ||
| const std::string& device_name, | ||
| const ov::AnyMap& properties); | ||
|
|
There was a problem hiding this comment.
Please describe scenarios how this new API is used.
There was a problem hiding this comment.
Please add tests to cover new API calls
There was a problem hiding this comment.
hi, sorry for the confusion. This draft PR is a temporary patch proposed to solve the customer issue and will not be applied into OV.
| @@ -101,6 +101,8 @@ void AutoSchedule::init() { | |||
| auto load_device_task = [&](AutoCompileContext* context_ptr, const std::shared_ptr<ov::Model>& model) { | |||
| try_to_compile_model(*context_ptr, model); | |||
| if (context_ptr->m_is_load_success) { | |||
| // release cloned model here | |||
| const_cast<std::shared_ptr<ov::Model>&>(model).reset(); | |||
There was a problem hiding this comment.
please change argument type instead of const cast
|
This PR will be closed in a week because of 2 weeks of no activity. |
|
This PR was closed because it has been stalled for 2 week with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: