Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PT FE] Support aten::atan2 for pytorch models #27026

Merged
merged 13 commits into from
Oct 23, 2024
Merged

[PT FE] Support aten::atan2 for pytorch models #27026

merged 13 commits into from
Oct 23, 2024

Conversation

tiebreaker4869
Copy link
Contributor

Details:

  • add atan2 operator and unit tests

Tickets:

@tiebreaker4869 tiebreaker4869 requested a review from a team as a code owner October 14, 2024 06:24
@github-actions github-actions bot added the category: PyTorch FE OpenVINO PyTorch Frontend label Oct 14, 2024
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Oct 14, 2024
@rkazants
Copy link
Member

build_jenkins

@mlukasze mlukasze linked an issue Oct 15, 2024 that may be closed by this pull request
[Good First Issue]: Support aten::atan2 for pytorch models #20575
Closed
@mlukasze
Copy link
Contributor

clang format check fails, fix it, please

mvafin
mvafin requested changes Oct 15, 2024
View reviewed changes
src/frontends/pytorch/src/op/atan2.cpp Outdated Show resolved Hide resolved
src/frontends/pytorch/src/op/atan2.cpp Outdated Show resolved Hide resolved
@tiebreaker4869 tiebreaker4869 requested a review from mvafin October 17, 2024 04:40
mvafin
mvafin requested changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@mvafin mvafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good

src/frontends/pytorch/src/op/atan2.cpp Outdated Show resolved Hide resolved
@mvafin
Copy link
Contributor

mvafin commented Oct 17, 2024

Tests for torch.export are failing. Please add aten.atan2.default to fx ops table

@tiebreaker4869 tiebreaker4869 requested a review from mvafin October 18, 2024 03:07
@tiebreaker4869
Copy link
Contributor Author

hi @mvafin are there any further changes i need to make? :)

@mvafin
Copy link
Contributor

mvafin commented Oct 21, 2024

build_jenkins

mvafin
mvafin approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@mvafin mvafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiebreaker4869 Thank you for contribution

@mvafin mvafin added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2024
@mvafin mvafin added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2024
@mvafin mvafin added this pull request to the merge queue Oct 23, 2024
Merged via the queue into openvinotoolkit:master with commit c5e16fc Oct 23, 2024
158 of 160 checks passed
@mlukasze mlukasze added this to the 2024.5 milestone Oct 23, 2024
CuriousPanCake pushed a commit to CuriousPanCake/openvino that referenced this pull request Nov 6, 2024
@tiebreaker4869 @mlukasze
@mvafin @CuriousPanCake
[PT FE] Support aten::atan2 for pytorch models (openvinotoolkit#27026)
b90846d 
### Details:
- add atan2 operator and unit tests

### Tickets:
- [[Good First Issue]: Support aten::atan2 for pytorch
models](openvinotoolkit#20575)

---------

Co-authored-by: Michal Lukaszewski <michal.lukaszewski@intel.com>
Co-authored-by: Maxim Vafin <maxim.vafin@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvafin mvafin mvafin approved these changes

@PiotrKrzem PiotrKrzem Awaiting requested review from PiotrKrzem PiotrKrzem is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

@cavusmustafa cavusmustafa Awaiting requested review from cavusmustafa cavusmustafa is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

Assignees

@mvafin mvafin

Labels
category: PyTorch FE OpenVINO PyTorch Frontend ExternalPR External contributor
Projects
None yet
Milestone
2024.5
Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Support aten::atan2 for pytorch models
5 participants
@tiebreaker4869 @rkazants @mlukasze @mvafin @sys-openvino-ci