Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated common IE pipeline infer-request section #10844

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Updated common IE pipeline infer-request section #10844

merged 3 commits into from
Mar 9, 2022

Conversation

ilya-lavrenov
Copy link
Contributor

Details:

  • Moved link to infer request from dedicated section when we are running inference request
  • Added notes when set_callback should be used
  • Removed duplication of main page's "Run inference" and inference requests details

@ilya-lavrenov ilya-lavrenov added the port to master Required port to master from 2022.3 LTS label Mar 9, 2022
@ilya-lavrenov ilya-lavrenov requested a review from a team as a code owner March 9, 2022 11:57
@ilya-lavrenov ilya-lavrenov requested review from tsavina and removed request for a team March 9, 2022 11:57
@ilya-lavrenov ilya-lavrenov added this to the 2022.1 milestone Mar 9, 2022
myshevts
myshevts reviewed Mar 9, 2022
View reviewed changes
docs/OV_Runtime_UG/ov_infer_request.md Outdated
> **NOTE**: Use weak reference of infer_request (`ov::InferRequest*`, `ov::InferRequest&`, `std::weal_ptr<ov::InferRequest>` and etc) in the callback, it is needed to avoid cyclic references.
For more details please take a look too [Classification Sample Async](../../samples/cpp/classification_sample_async/README.md).

You can use `ov::InferRequest::cancel` method in case if you want to abort execution of the current inference request:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works only on the CPU afaik... @vladimir-paramuzov ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but for other plugins it does nothing (no "not implemented" exception is thrown)

kblaszczak-intel
kblaszczak-intel reviewed Mar 9, 2022
View reviewed changes
Copy link
Contributor

@kblaszczak-intel kblaszczak-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions provided, mostly minor grammar stuff.

@ilya-lavrenov @kblaszczak-intel
Apply suggestions from code review
0f636d1 
Co-authored-by: Karol Blaszczak <karol.blaszczak@intel.com>
@ilya-lavrenov ilya-lavrenov enabled auto-merge (squash) March 9, 2022 13:59
@azhogov azhogov disabled auto-merge March 9, 2022 14:33
@azhogov azhogov merged commit 8308b1e into openvinotoolkit:releases/2022/1 Mar 9, 2022
@ilya-lavrenov ilya-lavrenov deleted the common-guide branch March 9, 2022 14:35
ilya-lavrenov added a commit to ilya-lavrenov/openvino that referenced this pull request Mar 18, 2022
@ilya-lavrenov @myshevts @kblaszczak-intel
Updated common IE pipeline infer-request section (openvinotoolkit#10844)
3c166a4 
* Updated common IE pipeline infer-reqest section

* Update ov_infer_request.md

* Apply suggestions from code review

Co-authored-by: Karol Blaszczak <karol.blaszczak@intel.com>

Co-authored-by: Maxim Shevtsov <maxim.y.shevtsov@intel.com>
Co-authored-by: Karol Blaszczak <karol.blaszczak@intel.com>
@ilya-lavrenov ilya-lavrenov added ported to master Ported from 2022.x branches to master and removed port to master Required port to master from 2022.3 LTS labels Mar 18, 2022
azhogov pushed a commit that referenced this pull request Mar 18, 2022
@ilya-lavrenov @myshevts
@tsavina @kblaszczak-intel @alvoron @terfendail @ilyachur @xu-yuan1 @vyashina @ntyukaev
DOCS: port changes from releases/2022/1 (#11040)
e3098ec 
* Added migration for deployment (#10800)

* Added migration for deployment

* Addressed comments

* more info after the What's new Sessions' questions (#10803)

* more info after the What's new Sessions' questions

* generalizing the optimal_batch_size vs explicit value message

* Update docs/OV_Runtime_UG/automatic_batching.md

Co-authored-by: Tatiana Savina <tatiana.savina@intel.com>

* Update docs/OV_Runtime_UG/automatic_batching.md

Co-authored-by: Tatiana Savina <tatiana.savina@intel.com>

* Update docs/OV_Runtime_UG/automatic_batching.md

Co-authored-by: Tatiana Savina <tatiana.savina@intel.com>

* Update docs/OV_Runtime_UG/automatic_batching.md

Co-authored-by: Tatiana Savina <tatiana.savina@intel.com>

* Update docs/OV_Runtime_UG/automatic_batching.md

Co-authored-by: Tatiana Savina <tatiana.savina@intel.com>

* Update docs/OV_Runtime_UG/automatic_batching.md

Co-authored-by: Tatiana Savina <tatiana.savina@intel.com>

Co-authored-by: Tatiana Savina <tatiana.savina@intel.com>

* Perf Hints docs and General Opt Guide refactoring (#10815)

* Brushed the general optimization page

* Opt GUIDE, WIP

* perf hints doc placeholder

* WIP

* WIP2

* WIP 3

* added streams and few other details

* fixed titles, misprints etc

* Perf hints

* movin the runtime optimizations intro

* fixed link

* Apply suggestions from code review

Co-authored-by: Tatiana Savina <tatiana.savina@intel.com>

* some details on the FIL and other means when pure inference time is not the only factor

* shuffled according to general->use-case->device-specifics flow, minor brushing

* next iter

* section on optimizing for tput and latency

* couple of links to the features support matrix

* Links, brushing, dedicated subsections for Latency/FIL/Tput

* had to make the link less specific (otherwise docs compilations fails)

* removing the Temp/Should be moved to the Opt Guide

* shuffled the tput/latency/etc info into separated documents. also the following docs moved from the temp into specific feature, general product desc or corresponding plugins

-   openvino_docs_IE_DG_Model_caching_overview
-   openvino_docs_IE_DG_Int8Inference
-   openvino_docs_IE_DG_Bfloat16Inference
-   openvino_docs_OV_UG_NoDynamicShapes

* fixed toc for ov_dynamic_shapes.md

* referring the openvino_docs_IE_DG_Bfloat16Inference to avoid docs compilation errors

* fixed main product TOC, removed ref from the second-level items

* reviewers remarks

* reverted the openvino_docs_OV_UG_NoDynamicShapes

* reverting openvino_docs_IE_DG_Bfloat16Inference and openvino_docs_IE_DG_Int8Inference

* "No dynamic shapes" to the "Dynamic shapes" as TOC

* removed duplication

* minor brushing

* Caching to the next level in TOC

* brushing

* more on the perf counters ( for latency and dynamic cases)

Co-authored-by: Tatiana Savina <tatiana.savina@intel.com>

* Updated common IE pipeline infer-request section (#10844)

* Updated common IE pipeline infer-reqest section

* Update ov_infer_request.md

* Apply suggestions from code review

Co-authored-by: Karol Blaszczak <karol.blaszczak@intel.com>

Co-authored-by: Maxim Shevtsov <maxim.y.shevtsov@intel.com>
Co-authored-by: Karol Blaszczak <karol.blaszczak@intel.com>

* DOCS: Removed useless 4 spaces in snippets (#10870)

* Updated snippets

* Added link to encryption

* [DOCS] ARM CPU plugin docs (#10885)

* initial commit

ARM_CPU.md added
ARM CPU is added to the list of supported devices

* Update the list of supported properties

* Update Device_Plugins.md

* Update CODEOWNERS

* Removed quotes in limitations section

* NVIDIA and Android are added to the list of supported devices

* Added See Also section and reg sign to arm

* Added Preprocessing acceleration section

* Update the list of supported layers

* updated list of supported layers

* fix typos

* Added support disclaimer

* update trade and reg symbols

* fixed typos

* fix typos

* reg fix

* add reg symbol back

Co-authored-by: Vitaly Tuzov <vitaly.tuzov@intel.com>

* Try to fix visualization (#10896)

* Try to fix visualization

* New try

* Update Install&Deployment for migration guide to 22/1 (#10933)

* updates

* update

* Getting started improvements (#10948)

* Onnx updates (#10962)

* onnx changes

* onnx updates

* onnx updates

* fix broken anchors api reference (#10976)

* add ote repo (#10979)

* DOCS: Increase content width (#10995)

* fixes

* fix

* Fixed compilation

Co-authored-by: Maxim Shevtsov <maxim.y.shevtsov@intel.com>
Co-authored-by: Tatiana Savina <tatiana.savina@intel.com>
Co-authored-by: Karol Blaszczak <karol.blaszczak@intel.com>
Co-authored-by: Aleksandr Voron <aleksandr.voron@intel.com>
Co-authored-by: Vitaly Tuzov <vitaly.tuzov@intel.com>
Co-authored-by: Ilya Churaev <ilya.churaev@intel.com>
Co-authored-by: Yuan Xu <yuan1.xu@intel.com>
Co-authored-by: Victoria Yashina <victoria.yashina@intel.com>
Co-authored-by: Nikolay Tyukaev <nikolay.tyukaev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kblaszczak-intel kblaszczak-intel kblaszczak-intel left review comments

@myshevts myshevts myshevts approved these changes

@ilyachur ilyachur Awaiting requested review from ilyachur

@tsavina tsavina Awaiting requested review from tsavina tsavina is a code owner automatically assigned from openvinotoolkit/openvino-docs-maintainers

@vyashina vyashina Awaiting requested review from vyashina

Assignees
No one assigned
Labels
ported to master Ported from 2022.x branches to master
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.
4 participants
@ilya-lavrenov @myshevts @kblaszczak-intel @azhogov