-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MO] move importlib-metadata into setup.py #10319
[MO] move importlib-metadata into setup.py #10319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need importlib-metadata
in requirements.txt file? no other tools use it. I propose to remove it and this change is not needed at all
We need We are willing to make this as default recommended path to use MO therefore we can not remove this from requirements. But if my changes look too risky we can make this package required for both windows and linux or/and for all versions of python. And close this PR. This should not cause any harm since the package is lightweight. |
@pavel-esir, please remove |
ok, i'll do this |
Moved importlib-metadata into setup.py, @rkazants please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Root cause analysis: during requirements check MO was not handling
and
marker whensys_platform
andpython_version
are specified simultaneously, e.g.importlib-metadata; python_version < "3.8" and sys_platform == "win32"
and shows warning:Solution: Moved importlib-metadata from requirements.txt into setup.py
Ticket: CVS-77062
Code:
Validation:
Documentation: