Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue] [ARM]: Implement CPU plugin just-in-time emitter for LogicalXor operation #24108

Closed
eshoguli opened this issue Apr 18, 2024 · 15 comments
Assignees
Labels
category: CPU OpenVINO CPU plugin good first issue Good for newcomers no_stale Do not mark as stale platform: arm OpenVINO on ARM / ARM64
Milestone

Comments

@eshoguli
Copy link
Contributor

eshoguli commented Apr 18, 2024

Context

JIT Emitters are part of code generation feature (a.k.a. tensor compiler) that automatically produces highly-efficient optimized fused subgraph binary code. Each emitter implements specific operation from low level OpenVINO dialect.

Prerequisites

Recommended to use ARM CPU based platform for development (e.g. Mac, Raspberry Pi etc). Emulators (e.g. QEMU) is still an option, but not that convenient, especially for final performance evaluation.

What needs to be done?

Before emitter implementation, please, modify tests to be sure that deveoped functionality is covered by test:

Tests

Tests are disabled in default build, so ensure to add -DENABLE_TESTS=ON into cmake command.

GoogleTest is used for testing. CPU functional test target is ov_cpu_func_tests. You can use two GoogleTest filters for element-wise and activation operations:

  • for element-wise operations:
./bin/[platform]/[build_type]/ov_cpu_func_tests --gtest_filter="*smoke*Eltwise*"
  • for activations:
./bin/[platform]/[build_type]/ov_cpu_func_tests --gtest_filter="*smoke*Activation*"

Example Pull Requests

Resources

Contact points

@eshoguli, @dmitry-gorokhov

Ticket

CVS-137694

@eshoguli eshoguli added good first issue Good for newcomers no_stale Do not mark as stale labels Apr 18, 2024
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Apr 18, 2024
@eshoguli eshoguli added category: CPU OpenVINO CPU plugin platform: arm OpenVINO on ARM / ARM64 labels Apr 18, 2024
@ghost
Copy link

ghost commented Apr 20, 2024

Hello sir , I want to work on this issue, can you give me a detailed direction. i am a new here.

@eshoguli
Copy link
Contributor Author

Hello sir , I want to work on this issue, can you give me a detailed direction. i am a new here.

Hi @sagar-vinay-Em, can you, please, explore the content in the provided links and ask a more detailed question, please?

@westenwang
Copy link

#WLB#+ .take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze
Copy link
Contributor

mlukasze commented Apr 23, 2024

hey @westenwang

I found you took three tickets, for two different platforms.
On which one of them do you want to work for now?

@westenwang
Copy link

hey @westenwang

I found you took three tickets, for two different platforms. On which one of them do you want to work for now?

ARM

@p-wysocki p-wysocki moved this from Contributors Needed to Assigned in Good first issues Apr 24, 2024
@p-wysocki
Copy link
Contributor

Hello @westenwang, are you still working on that issue? Do you need any help?

@dmitry-gorokhov
Copy link
Contributor

I am moving the issue to unassigned state due to lack of activity for a long period of time.

@dmitry-gorokhov dmitry-gorokhov moved this from Assigned to Contributors Needed in Good first issues Jul 12, 2024
@awayzjj
Copy link
Contributor

awayzjj commented Jul 12, 2024

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@dmitry-gorokhov dmitry-gorokhov moved this from Contributors Needed to Assigned in Good first issues Jul 12, 2024
@mlukasze
Copy link
Contributor

hey @awayzjj will you work on this? (you have many tickets assigned)

@awayzjj awayzjj removed their assignment Jul 25, 2024
@awayzjj
Copy link
Contributor

awayzjj commented Jul 25, 2024

@mlukasze Sorry for the unconvinence! I have unassigned me! I will work on this when I have time if it is still open.

@mlukasze mlukasze moved this from Assigned to Contributors Needed in Good first issues Jul 25, 2024
@nashez
Copy link
Contributor

nashez commented Sep 27, 2024

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Sep 27, 2024
nashez added a commit to nashez/openvino that referenced this issue Sep 29, 2024
* Added a jit_logical_xor_emitter derived class in
  aarch64/jit_eltwise_emitters
* Created entry Algorithm::EltwiseLogicalXor in the
  get_supported_precisions in nodes/kernels/aarch64
* Add the EltwiseLogicalXor entry in the aarch64
  executors supported algorithms

Closes: openvinotoolkit#24108

Signed-off-by: Nashez Zubair <nashezzubair@gmail.com>
github-merge-queue bot pushed a commit that referenced this issue Sep 30, 2024
### Details:
- Added a jit_logical_xor_emitter derived class in
aarch64/jit_eltwise_emitters
- Created entry Algorithm::EltwiseLogicalXor in the
get_supported_precisions in nodes/kernels/aarch64
- Add the EltwiseLogicalXor entry in the aarch64 executors supported
algorithms

### Tickets:
 - #24108

Signed-off-by: Nashez Zubair <nashezzubair@gmail.com>
@nashez
Copy link
Contributor

nashez commented Oct 4, 2024

@mlukasze Changes have been merged to master. Can you close this please?

@alvoron alvoron closed this as completed Oct 4, 2024
@github-project-automation github-project-automation bot moved this from Assigned to Closed in Good first issues Oct 4, 2024
@alvoron alvoron added this to the 2024.5 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin good first issue Good for newcomers no_stale Do not mark as stale platform: arm OpenVINO on ARM / ARM64
Projects
Archived in project
Development

No branches or pull requests

8 participants