-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changing dimensions of batch size, kv cache and num_input_heads #793
Merged
ilya-lavrenov
merged 20 commits into
openvinotoolkit:master
from
lamiayous:ly/handling_tensors_access_in_genai
Sep 6, 2024
Merged
Changes from 16 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
006c942
chanign dimensions of batch size, kv cache and num_input_heads
lamiayous 2f88d30
Merge branch 'master' of https://github.com/openvinotoolkit/openvino.…
lamiayous 7d5cb93
Support for Qwen and isolating changes to functions
lamiayous 0969051
indentation fix
lamiayous a5abd8f
Merge branch 'master' into ly/handling_tensors_access_in_genai
lamiayous 73181e3
Merge branch 'master' of https://github.com/openvinotoolkit/openvino.…
lamiayous d223867
Merge branch 'master' of https://github.com/openvinotoolkit/openvino.…
lamiayous e929a48
Merge branch 'ly/handling_tensors_access_in_genai' of https://github.…
lamiayous 323e1ce
Merge branch 'master' of https://github.com/openvinotoolkit/openvino.…
lamiayous bc84a24
fix
lamiayous c208f1f
passing KVAxesPosition to reshape_to_static
lamiayous be7a41c
typo fix
lamiayous a119bef
remove debug print
lamiayous 311c358
changed to strict model_type comparison
lamiayous 2896476
fix typo
lamiayous 7019379
Merge branch 'master' into ly/handling_tensors_access_in_genai
lamiayous 9bcaebd
Update src/cpp/src/llm_pipeline_static.cpp
lamiayous 6359a73
Merge branch 'master' into ly/handling_tensors_access_in_genai
ilya-lavrenov db7c28b
fix typo
lamiayous 88e6b0f
Merge branch 'ly/handling_tensors_access_in_genai' of https://github.…
lamiayous File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this approach https://github.com/openvinotoolkit/openvino.genai/blob/master/samples/cpp/prompt_lookup_decoding_lm/prompt_lookup_decoding_lm.cpp#L13 is not used? it seems generic and does not required model type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilya-lavrenov Yes, you're right. The only drawback is that this function cannot be used for
.blob
's case as they will be stateless + static.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is it supposed to pass compiled blob via current LLMPipeline API ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's on review so far: #811
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current solution aim to handle
qwen
/chatglm
cases that are crucial for now.But in general, I'd prefer using your approach but somewhere inside
StatefulToStateless
transformation, so that it could save necessarymetadata
that will be available from bothxml
/blob
formats.