Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added GIL release for time consuming methods. #1673

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Added GIL release for time consuming methods. #1673

wants to merge 10 commits into from
+149 −35

Conversation

popovaan
Copy link
Contributor

@popovaan popovaan commented Feb 4, 2025

Ticket: CVS-161082

@github-actions github-actions bot added category: text to image Text 2 image pipeline category: visual language Visual language pipeline category: whisper Whisper pipeline category: Python API Python API for GenAI labels Feb 4, 2025
ilya-lavrenov
ilya-lavrenov reviewed Feb 4, 2025
View reviewed changes
src/python/py_image_generation_models.cpp Outdated Show resolved Hide resolved
src/python/py_vlm_pipeline.cpp Outdated Show resolved Hide resolved
@ilya-lavrenov ilya-lavrenov added this to the 2025.1 milestone Feb 4, 2025
@github-actions github-actions bot added the category: tokenizers Tokenizer class or submodule update label Feb 5, 2025
@Wovchena
Copy link
Collaborator

Wovchena commented Feb 7, 2025

WWB tests (3.11) failure seems to be a real problem because it failed 3 times with the same reason

@popovaan
Copy link
Contributor Author

popovaan commented Feb 7, 2025

WWB tests (3.11) failure seems to be a real problem because it failed 3 times with the same reason

Yes, I see this issue and reproduced locally but still didn't find the solution. WWB fails with segfault in a subprocess, when gil_release is used in generate() of Image2ImagePipeline or Text2ImagePipeline. I'm investigating it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@Wovchena Wovchena Wovchena approved these changes

@iefode iefode iefode approved these changes

@as-suvorov as-suvorov Awaiting requested review from as-suvorov

Assignees

@ilya-lavrenov ilya-lavrenov

@iefode iefode

@as-suvorov as-suvorov

Labels
category: Python API Python API for GenAI category: text to image Text 2 image pipeline category: tokenizers Tokenizer class or submodule update category: visual language Visual language pipeline category: whisper Whisper pipeline
Projects
None yet
Milestone
2025.1
Development

Successfully merging this pull request may close these issues.
5 participants
@popovaan @Wovchena @ilya-lavrenov @iefode @as-suvorov