Allow overriding eos_token_id #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phi3_V eos_token_id has different values for GenerationConfig and Tokenizer. It's required to allow overriding the token_id to align with the sample from model cards. My patches to the original models are ignored: 1. https://huggingface.co/microsoft/Phi-3-vision-128k-instruct/discussions/68 2. https://huggingface.co/microsoft/Phi-3.5-vision-instruct/discussions/35
ilya-lavrenov
approved these changes
Jan 30, 2025
yatarkan
approved these changes
Jan 30, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
Phi3_V eos_token_id has different values for GenerationConfig and Tokenizer. It's required to allow overriding the token_id to align with the sample from model cards. My patches to the original models are ignored: 1. https://huggingface.co/microsoft/Phi-3-vision-128k-instruct/discussions/68 2. https://huggingface.co/microsoft/Phi-3.5-vision-instruct/discussions/35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phi3_V eos_token_id has different values for GenerationConfig and Tokenizer. It's required to allow overriding the token_id to align with the sample from model cards.
My patches to the original models are ignored: