Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a choice of how to end streaming from callback: STOP or CANCEL #1476
base: master
Are you sure you want to change the base?
Add a choice of how to end streaming from callback: STOP or CANCEL #1476
Changes from all commits
345f9be
02cd584
b642329
57f0fd4
67a77ef
360ceeb
0b59cc2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can add a new function
put_token
/write
with new return type and deprecate currentput
with binary status?IMO, it will be more future proof and removes ambiguity that authors of custom text streamers need to write functions like
is_generation_complete
CC @Wovchena @sbalandi @as-suvorov what do you think?
BTW, if you are OK with new method, note, that we need to select more or less generic name, which will allow to put a single token or multiple tokens (Whisper / Spec Dec cases)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have added new method, called it
write
.put_token
good for one token, but for chunkput_chunk
is used now and I'm not sure chunk is common name or it's okay change it totokens
? @as-suvorov what do you think ?Also maybe
post
is possible ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
write
is fine