[PT2] Introduce PT2OpLayerAttribute #3178
Open
+256
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nncf/experimental/torch2/function_hook/nncf_graph/nncf_graph_builder.py
Outdated
Show resolved
Hide resolved
nncf/experimental/torch2/function_hook/nncf_graph/layer_attributes.py
Outdated
Show resolved
Hide resolved
| """ | ||
| if isinstance(meta, FunctionMeta): | ||
| constant_port_ids = get_constant_port_ids(nx_graph, node) | ||
| return PT2OpLayerAttributes(meta.func, meta.args, meta.kwargs, constant_port_ids) |
There was a problem hiding this comment.
Why do we need both constant_port_ids in PT2OpLayerAttributes and weights_port_id in the metatypes? https://github.com/openvinotoolkit/nncf/blob/develop/nncf/torch/graph/operator_metatypes.py#L207
There was a problem hiding this comment.
constant_port_ids collects all constanat ports like weights and bias.
weights_port_id needs to find only weight.
There was a problem hiding this comment.
Ok, there are models with constant subgraphs which contain linear layers (swin_v2), does you approach cover such cases? In torch FX such nodes have 3 constant inputs
There was a problem hiding this comment.
All 3 inputs marks as constants
daniil-lyakhov
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
PT2OpLayerAttribute, to collect called function, attributes and constant portsFunctionMetastored function instead of function nameReason for changes
Needs to implement subgraph extractor for FBC
Related tickets
110974
Tests
tests/torch2/function_hook/nncf_graph/test_layer_attributes.py