Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update core API docs: Adapter and Model #242

Merged
merged 6 commits into from
Dec 12, 2024
Merged

Update core API docs: Adapter and Model #242

merged 6 commits into from
Dec 12, 2024

Conversation

sovrasov
Copy link
Collaborator

What does this PR do?

Update the inline docs for adapter and model.

@sovrasov sovrasov added this to the 0.2.6 milestone Dec 10, 2024
@github-actions github-actions bot added the python python related changes label Dec 10, 2024
ashwinvaidya17
ashwinvaidya17 reviewed Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good. Two very minor comments

model_api/python/model_api/adapters/inference_adapter.py Outdated Show resolved Hide resolved
model_api/python/model_api/models/model.py Outdated Show resolved Hide resolved
@sovrasov @ashwinvaidya17
Apply suggestions
e8bb296 
Co-authored-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
@sovrasov
Copy link
Collaborator Author

Thanks looks good. Two very minor comments

Thanks, applied your suggestions

@sovrasov sovrasov added this pull request to the merge queue Dec 12, 2024
Merged via the queue into openvinotoolkit:master with commit 17f3f18 Dec 12, 2024
16 checks passed
@sovrasov sovrasov deleted the vs/upda_api_docs branch December 12, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 approved these changes

Assignees
No one assigned
Labels
python python related changes
Projects
None yet
Milestone
0.2.6
Development

Successfully merging this pull request may close these issues.
2 participants
@sovrasov @ashwinvaidya17