Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arrow format patch error on python 3.7 #939

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

cih9088
Copy link
Contributor

@cih9088 cih9088 commented Apr 14, 2023

Summary

Disentangle temporary directory management

  • Fixed to remove and move manually each files instead of whole directory itself.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
@cih9088 cih9088 added the BUG Something isn't working label Apr 14, 2023
@cih9088 cih9088 added this to the 1.2.0 milestone Apr 14, 2023
@cih9088 cih9088 requested review from a team as code owners April 14, 2023 11:11
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2023

Codecov Report

Patch coverage: 77.77% and project coverage change: -0.01 ⚠️

Comparison is base (eaae1e1) 78.65% compared to head (b9db137) 78.64%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.2.0     #939      +/-   ##
==================================================
- Coverage           78.65%   78.64%   -0.01%     
==================================================
  Files                 228      228              
  Lines               26342    26349       +7     
  Branches             5249     5252       +3     
==================================================
+ Hits                20718    20722       +4     
- Misses               4406     4407       +1     
- Partials             1218     1220       +2     
Flag Coverage Δ
macos-11_Python-3.8 77.66% <77.77%> (-0.01%) ⬇️
ubuntu-20.04_Python-3.8 78.62% <77.77%> (-0.01%) ⬇️
windows-2019_Python-3.8 78.52% <77.77%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/plugins/data_formats/arrow/exporter.py 75.00% <77.77%> (-0.13%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wonjuleee wonjuleee merged commit e6d73a0 into openvinotoolkit:releases/1.2.0 Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants