Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log issue when importing celeba and align celeba dataset #919

Merged
merged 3 commits into from
Apr 7, 2023

Conversation

sooahleex
Copy link
Contributor

@sooahleex sooahleex commented Apr 6, 2023

Summary

When import celeba or align_celeba dataset without format like dm.Dataset.import_from(path=...), we met error like below. The example is the case for importing align_celeba dataset.

ERROR:root:Cannot find celeba's images directory at tests/assets/align_celeba_dataset/dataset/Img/img_celeba

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@sooahleex sooahleex added the BUG Something isn't working label Apr 6, 2023
@sooahleex sooahleex added this to the 1.2.0 milestone Apr 6, 2023
@sooahleex sooahleex requested review from a team as code owners April 6, 2023 07:38
@sooahleex sooahleex force-pushed the bug/import-celeba branch from 2f089ef to e423085 Compare April 6, 2023 07:39
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: -2.85 ⚠️

Comparison is base (89b2111) 78.87% compared to head (e423085) 76.02%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #919      +/-   ##
===========================================
- Coverage    78.87%   76.02%   -2.85%     
===========================================
  Files          210      231      +21     
  Lines        25145    26508    +1363     
  Branches      5036     5298     +262     
===========================================
+ Hits         19832    20153     +321     
- Misses        4178     5195    +1017     
- Partials      1135     1160      +25     
Flag Coverage Δ
macos-11_Python-3.8 75.06% <83.33%> (-2.80%) ⬇️
ubuntu-20.04_Python-3.8 76.01% <83.33%> (-2.85%) ⬇️
windows-2019_Python-3.8 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/plugins/data_formats/celeba/celeba.py 74.05% <83.33%> (+0.63%) ⬆️

... and 30 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sooahleex sooahleex merged commit ddde11d into openvinotoolkit:develop Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants