Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MARS (Import only) #585

Merged
merged 24 commits into from
Dec 28, 2021
Merged

Add MARS (Import only) #585

merged 24 commits into from
Dec 28, 2021

Conversation

sizov-kirill
Copy link

@sizov-kirill sizov-kirill commented Dec 17, 2021

Summary

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@sizov-kirill sizov-kirill changed the title Add MARS (Import only) [WIP] Add MARS (Import only) Dec 17, 2021
@sizov-kirill sizov-kirill changed the title [WIP] Add MARS (Import only) Add MARS (Import only) Dec 17, 2021
@sizov-kirill sizov-kirill requested a review from IRDonch December 19, 2021 11:58
@zhiltsov-max zhiltsov-max linked an issue Dec 20, 2021 that may be closed by this pull request
site/content/en/docs/formats/mars.md Outdated Show resolved Hide resolved
site/content/en/docs/formats/mars.md Outdated Show resolved Hide resolved
## Format specification

MARS is a dataset for and motion analysis and person identification task,
and this dataset it's extension of Market-1501 dataset format.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be no verb here.

site/content/en/docs/formats/mars.md Outdated Show resolved Hide resolved
site/content/en/docs/formats/mars.md Outdated Show resolved Hide resolved
site/content/en/docs/formats/mars.md Outdated Show resolved Hide resolved
site/content/en/docs/formats/mars.md Outdated Show resolved Hide resolved
site/content/en/docs/formats/mars.md Outdated Show resolved Hide resolved
site/content/en/docs/formats/mars.md Outdated Show resolved Hide resolved
tests/test_mars_format.py Outdated Show resolved Hide resolved
@sizov-kirill sizov-kirill changed the title Add MARS (Import only) [WIP] Add MARS (Import only) Dec 21, 2021
@sizov-kirill
Copy link
Author

I fixed all comments and updated market1501 format for compatibility with mars format, there is changes that I made for market1501:

  • Importer: made heuristic more unique
  • Extractor: made query items as separate subset, because the original dataset don't suppose that query image relate with images from other subsets
  • Load items: added attributes according original dataset description (I used track_id instead of sequence_id because these two attributes have the same meaning)
  • Converter: implemented this strategy: if item has person_id attribute Converter try to save this item with original image naming convention, using default values for unknown attributes and incrementing frame_id for collisions.

I decided to keep both person_id attribute and Label for MARS format for compatibility with classification-task formats.
I also used the str type for person_id, for cases where users would like to mark some items with a special identifier.

@sizov-kirill sizov-kirill changed the title [WIP] Add MARS (Import only) Add MARS (Import only) Dec 27, 2021
Copy link
Contributor

@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please update Market docs.

@zhiltsov-max zhiltsov-max merged commit e987cf5 into develop Dec 28, 2021
@zhiltsov-max zhiltsov-max deleted the sk/add-mars-format branch December 28, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support MARS (reid) dataset
3 participants