Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle path separators in the subset when exporting a datumaro dataset #1615

Conversation

jihyeonyi
Copy link

@jihyeonyi jihyeonyi commented Sep 20, 2024

Summary

Ticket: 152928
Raise an error when exporting a dataset in Datumaro format if the subset name contains path separators.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@jihyeonyi jihyeonyi changed the base branch from develop to releases/1.9.0 September 24, 2024 02:32
@jihyeonyi jihyeonyi force-pushed the jihyeony/152928_remove-path-separators branch from 7da2334 to ae61353 Compare September 24, 2024 02:37
@jihyeonyi jihyeonyi changed the title Remove path separator from id and subset when exporting datumaro dataset Handle path separators in the subset when exporting a datumaro dataset Sep 24, 2024
@jihyeonyi jihyeonyi marked this pull request as ready for review September 24, 2024 02:45
@jihyeonyi jihyeonyi requested review from a team as code owners September 24, 2024 02:45
@jihyeonyi jihyeonyi requested review from sooahleex and removed request for a team September 24, 2024 02:45
@jihyeonyi jihyeonyi changed the base branch from releases/1.9.0 to develop September 24, 2024 02:57
@jihyeonyi jihyeonyi force-pushed the jihyeony/152928_remove-path-separators branch from c8a0133 to 1952f07 Compare September 24, 2024 03:02
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.07%. Comparing base (ff5fd94) to head (59074ac).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
src/datumaro/components/errors.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1615      +/-   ##
===========================================
+ Coverage    81.06%   81.07%   +0.01%     
===========================================
  Files          278      278              
  Lines        32517    32588      +71     
  Branches      6607     6620      +13     
===========================================
+ Hits         26360    26422      +62     
- Misses        4701     4710       +9     
  Partials      1456     1456              
Flag Coverage Δ
ubuntu-20.04_Python-3.10 81.06% <95.45%> (+0.01%) ⬆️
windows-2022_Python-3.10 81.05% <95.45%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jihyeonyi jihyeonyi merged commit dc9bbf2 into openvinotoolkit:develop Sep 25, 2024
8 checks passed
@jihyeonyi jihyeonyi deleted the jihyeony/152928_remove-path-separators branch September 25, 2024 04:32
@jihyeonyi jihyeonyi added this to the 1.10.0 milestone Sep 25, 2024
@jihyeonyi jihyeonyi added the ENHANCE Enhancement of existing features label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENHANCE Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants