Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dtype argument when calling media.data #1546

Merged
merged 8 commits into from
Jun 28, 2024

Conversation

wonjuleee
Copy link
Contributor

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@wonjuleee wonjuleee requested review from a team as code owners June 25, 2024 05:29
@wonjuleee wonjuleee requested review from sooahleex and removed request for a team June 25, 2024 05:29
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (63da2ff) to head (33915d2).
Report is 12 commits behind head on develop.

Files Patch % Lines
src/datumaro/components/media.py 72.22% 4 Missing and 1 partial ⚠️
src/datumaro/util/image.py 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1546      +/-   ##
===========================================
- Coverage    81.05%   81.03%   -0.03%     
===========================================
  Files          276      276              
  Lines        32359    32417      +58     
  Branches      6575     6591      +16     
===========================================
+ Hits         26230    26270      +40     
- Misses        4684     4693       +9     
- Partials      1445     1454       +9     
Flag Coverage Δ
ubuntu-20.04_Python-3.10 81.02% <78.12%> (-0.03%) ⬇️
windows-2022_Python-3.10 81.01% <78.12%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a question, is there any reason to add dtype as argument?

@wonjuleee wonjuleee marked this pull request as draft June 25, 2024 07:26
@wonjuleee wonjuleee marked this pull request as ready for review June 28, 2024 01:22
@wonjuleee wonjuleee merged commit 6a92276 into openvinotoolkit:develop Jun 28, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants