-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dtype argument when calling media.data #1546
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1546 +/- ##
===========================================
- Coverage 81.05% 81.03% -0.03%
===========================================
Files 276 276
Lines 32359 32417 +58
Branches 6575 6591 +16
===========================================
+ Hits 26230 26270 +40
- Misses 4684 4693 +9
- Partials 1445 1454 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just a question, is there any reason to add dtype
as argument?
Summary
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.