Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD pipeline training and inference UI #729

Closed
wants to merge 3 commits into from
Closed

ADD pipeline training and inference UI #729

wants to merge 3 commits into from

Conversation

vnk8071
Copy link

@vnk8071 vnk8071 commented Nov 23, 2022

Description

As issue #721, I have already create a pipeline for training and inferencing using UI. More details in README.md in tools/pipeline folder

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@github-actions github-actions bot added the Tools label Nov 23, 2022
@vnk8071
Copy link
Author

vnk8071 commented Nov 23, 2022

I forgot to add label enhancement and I would assign @ashwinvaidya17 to review my PR.

@ashwinvaidya17
Copy link
Collaborator

Thanks for your hard work! The team is a bit occupied with some stuff but we will review your PR soon :)

@jpcbertoldo
Copy link
Contributor

The idea of having a web app for interacting with anomalib is really cool, but IMO it would be better to keep it as separate project.

Feels like a lot of code that would come in and probably wouldn't get enough attention to be properly maintained as the core library evolves -- it's already challenging to keep up with the tests : /

And there is some data coming in (tools/pipeline/data), which doesn't feel like something that should be making the repo heavier for everyone else who wouldn't use the web app -- still, the idea is very nice because it opens the door to more users!

Suggestion: a link in the documentation pointing to your (standalone) project would to the job?

@vnk8071
Copy link
Author

vnk8071 commented Nov 25, 2022

@jpcbertoldo First of all, I would like to thanks for your suggestion. Initial I thought to this problems and it really hard to pass the tests.

So where I can push my document in Anomalib repo to forwarding to my project and everyone can use it. And can I create a header like pipeline training and inference on UI then write more description to README.md or I create a pipeline.md into tools directory like my current README.md file? And I will update lastest version when Anomalib release new version.

Best.

@ashwinvaidya17
Copy link
Collaborator

I agree with @jpcbertoldo. Since we have a small team, maintenance will be challenging for us and might detract from the core repository. It is better if this remains a separate repository. We can always link to this in the README, and you can also create a post with screenshots here https://github.com/openvinotoolkit/anomalib/discussions/categories/show-and-tell. We can also create an entry on our documentation (https://openvinotoolkit.github.io/anomalib/) to point to your project. This way, you will also retain the flexibility to update your pipeline as quickly as needed. With that said, the entire team appreciates your hardwork and it is very encouraging to see people build cool stuff using our library.

@vnk8071
Copy link
Author

vnk8071 commented Nov 25, 2022

Thanks @ashwinvaidya17 @jpcbertoldo for quickly comment and give some suggestions. And I have already create discussion show and tell with title Pipeline training and inference on UI (#733). Can guys see my discuss and feedback for improving complete my contribute.

I am very happiness to contribute little things useful from Anomalib library.

@ashwinvaidya17
Copy link
Collaborator

@vnk8071 Can I close this PR? Also, would you be willing to create a PR to add a section for Community Projects in the readme and point to the Discussion and your github repo? Otherwise I can create a PR for that.

@vnk8071
Copy link
Author

vnk8071 commented Dec 1, 2022

Yes. I will create a PR to add a section for Community Projects in the readme and point to the Discussion and my Github repo. Thank @ashwinvaidya17 so much to your supports and I closed this PR.

@vnk8071 vnk8071 closed this Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants