Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ CS-Flow model #657

Merged
merged 32 commits into from
Dec 20, 2022
Merged

✨ CS-Flow model #657

merged 32 commits into from
Dec 20, 2022

Conversation

ashwinvaidya17
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 commented Oct 31, 2022

Description

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@github-actions github-actions bot added Dependencies Pull requests that update a dependency file Setup Tests labels Oct 31, 2022
@github-actions github-actions bot added the Docs label Nov 14, 2022
@ashwinvaidya17 ashwinvaidya17 marked this pull request as ready for review November 25, 2022 08:42
@github-actions github-actions bot added the CI label Nov 28, 2022
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for diving into this algo and adding the implementation. I have a few comments concerning the readability, but overall the PR looks good!

anomalib/models/__init__.py Outdated Show resolved Hide resolved
anomalib/models/cs_flow/config.yaml Outdated Show resolved Hide resolved
anomalib/models/cs_flow/lightning_model.py Outdated Show resolved Hide resolved
anomalib/models/cs_flow/lightning_model.py Outdated Show resolved Hide resolved
anomalib/models/cs_flow/lightning_model.py Outdated Show resolved Hide resolved
anomalib/models/cs_flow/torch_model.py Outdated Show resolved Hide resolved
anomalib/models/cs_flow/torch_model.py Outdated Show resolved Hide resolved
anomalib/models/cs_flow/torch_model.py Outdated Show resolved Hide resolved
anomalib/models/cs_flow/torch_model.py Outdated Show resolved Hide resolved
anomalib/models/cs_flow/torch_model.py Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the CI label Nov 29, 2022
@ashwinvaidya17
Copy link
Collaborator Author

I think I've addressed all the comments.

Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, few comments left, mainly minor

anomalib/models/csflow/torch_model.py Outdated Show resolved Hide resolved
anomalib/models/csflow/torch_model.py Outdated Show resolved Hide resolved
anomalib/models/csflow/torch_model.py Show resolved Hide resolved
anomalib/models/csflow/torch_model.py Outdated Show resolved Hide resolved
Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgot to approve this. But I'm happy with the changes, so let's get this merged

@ashwinvaidya17 ashwinvaidya17 merged commit 997272a into main Dec 20, 2022
@ashwinvaidya17 ashwinvaidya17 deleted the feature/ashwin/cs-flow branch December 20, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file Setup Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CS-Flow Model
3 participants