-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor PreProcessor
and fix Visualizer
denormalization issue.
#570
Conversation
…anomalib into fix/sa/custom-data-normalization
…a/custom-data-normalization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I don't have anything to add here
logger = logging.getLogger(__name__) | ||
|
||
|
||
def get_transforms( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also move this function to data/utils
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is still one of the most important components of pre-processing
sub-package. If we move it to data/utils
, then pre_processing
would become quite a weak package that we could consider removing in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case we could ask ourselves if we really need the pre-processing
module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that's the question, I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm merging this one, we could discuss this later on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in the meeting, we could probably deprecate the PreProcessor class now that it's reduced to a wrapper around the get_transforms
function. It would require some changes to the datamodule, so let's address this once the datamodule refactor has been merged.
Description
Fix
Visualizer
denormalization issue.Refactor
PreProcessor
to improve the flexibility of getting the transforms without relying on aPreProcessor
object.Refactor
read_image
to add flexibility of resizing the image while reading.Fixes Allow custom Data Normalization and consider it in Post-processing #512
Changes
Checklist