-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/comet logging #517
Feature/comet logging #517
Conversation
…omalib into feature/comet_logging
…omalib into feature/comet_logging
Co-authored-by: Boris Feld <lothiraldan@gmail.com>
Co-authored-by: Boris Feld <lothiraldan@gmail.com>
Co-authored-by: Boris Feld <lothiraldan@gmail.com>
Co-authored-by: Boris Feld <lothiraldan@gmail.com>
Co-authored-by: Boris Feld <lothiraldan@gmail.com>
@sherpan can you also have a look at https://github.com/openvinotoolkit/anomalib/runs/8065761026?check_suite_focus=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sherpan ! I have few minor comments.
Believe i resolved all of the comments! |
…omalib into feature/comet_logging
@sherpan, I was wondering if you could install
This would fix the issues, after which you could push your changes. |
hey samet, yeah i think you are right! will do that next time? Think i am passing everything now? |
That's peculiar. No worries, though. We'll sort out the rest. Thanks a lot for the contribution! Much appreciated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes
@sherpan There is probably something wrong with your environment. I am getting the same issues. |
Or maybe we can merge this branch and I can open a new PR for https://github.com/openvinotoolkit/anomalib/tree/fix/ashwin/linting. @samet-akcay @djdameln ? |
Description
Add comet as a potential logger for the repo
Changes
Checklist