Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore pixel metrics in classification task #516

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Ignore pixel metrics in classification task #516

merged 2 commits into from
Aug 29, 2022

Conversation

djdameln
Copy link
Contributor

Description

  • This PR makes sure that validation/testing does not fail when pixel metrics are requested in a classification task. Instead, the metrics configuration callback will ignore the pixel metrics and show a warning to the user.

  • Fixes Patchcore validation and test error! #513

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@djdameln djdameln requested a review from samet-akcay August 25, 2022 11:57
samet-akcay
samet-akcay reviewed Aug 25, 2022
View reviewed changes
anomalib/utils/callbacks/__init__.py Outdated
@@ -74,6 +74,7 @@ def get_callbacks(config: Union[ListConfig, DictConfig]) -> List[Callback]:
config.metrics.threshold.pixel_default if "pixel_default" in config.metrics.threshold.keys() else None
)
metrics_callback = MetricsConfigurationCallback(
config.dataset.task,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the same initialization is to be done when configuring MetricsConfigurationCallback in the new CLI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@github-actions github-actions bot added the CLI label Aug 29, 2022
ashwinvaidya17
ashwinvaidya17 approved these changes Aug 29, 2022
View reviewed changes
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

samet-akcay
samet-akcay approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@djdameln djdameln merged commit 65169ed into main Aug 29, 2022
@djdameln djdameln deleted the da/warn-user-incorrect-metrics branch August 29, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samet-akcay samet-akcay samet-akcay approved these changes

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 approved these changes

Assignees
No one assigned
Labels
CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Patchcore validation and test error!
3 participants
@djdameln @ashwinvaidya17 @samet-akcay