Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚚 Move perlin noise to common folder #424

Merged
merged 7 commits into from
Jul 15, 2022
Merged

🚚 Move perlin noise to common folder #424

merged 7 commits into from
Jul 15, 2022

Conversation

ashwinvaidya17
Copy link
Collaborator

Changes

  • Minor refactor

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

samet-akcay
samet-akcay reviewed Jul 11, 2022
View reviewed changes
anomalib/utils/generators/__init__.py Outdated
# Copyright (C) 2022 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

from .perlin import rand_perlin_2d_np
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe for another PR, but would be nice to rename the function as well.

samet-akcay
samet-akcay reviewed Jul 11, 2022
View reviewed changes
anomalib/models/draem/utils/augmenter.py Outdated
@@ -21,7 +21,7 @@
from torch import Tensor
from torchvision.datasets.folder import IMG_EXTENSIONS

from anomalib.models.draem.utils.perlin import rand_perlin_2d_np
from anomalib.utils.generators import rand_perlin_2d_np
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also have anomalib.data.utils directory? Would it be an idea to move this there ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. That's a good idea.

@samet-akcay samet-akcay merged commit 8f437b7 into development Jul 15, 2022
@samet-akcay samet-akcay deleted the ashwin/move_perlin_noise branch July 15, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samet-akcay samet-akcay samet-akcay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚚 Move Perlin Noise to common folder
2 participants
@ashwinvaidya17 @samet-akcay