Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug that caused too many matplotlib figures to be retained in memory.
visualizer.generate()
was unintentionally called twice for every image, causing the number of open images to build up as the test loop progressed. Fixed by leaving the responsibility of callingvisualizer.generate()
to the callback class instead of the visualizer itself.Note: Since this bug affected development, I target development in this PR. Will rebase the feature branch to pull in the changes there.
Changes
Checklist