-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
➕Add warnings ⚠️ for inproper task setting in config files. #274
➕Add warnings ⚠️ for inproper task setting in config files. #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will also address the comment on the issue about classification task producing only binary predictions rather than anomaly masks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the task type parameter really is redundant for the folder dataset. Especially now that performance metrics are configurable. The user can now choose between classification and segmentation evaluation in 3 ways: task_type
parameter, mask_path
parameter and metrics.pixel
parameter. In understand why this confuses the users, and I feel we need a better design for this. But let's merge this PR as a quick fix and create a better design separately.
I agree it's not so intuitive. We need to make it simpler. |
Description
This PR adds checks to see if the task is properly assigned in folder dataset.
Fixes Test anomalib with unsupervised dataset #273
Changes
Checklist